`Create` & `Update` should return `status code != 200` for failed requests

[a-nickol]

`Create` & `Update` should return `status code != 200` for failed requests

[a-nickol]

This change is probably unwanted, since of:

Inherited Resources is no longer actively maintained by the original author and has been transferred to the ActiveAdmin organization for maintenance. New feature requests are not encouraged.

[andriytyurnikov]

Oh fuck

[caifara]

Is this really a feature request? Returning a 200 after what is essentially a failed request could be seen as a bug.

As ActiveAdmin is in a period of more active development, I would think that a solution that properly works with Turbo is important.

I used to add data-turbo: false all over the place. After some investigation and seeing the connected PR, it could be solved by an initializer with:

InheritedResources::Responder.error_status = :unprocessable_entity

So, if not actually wanted in InheritedResources, that line could be part of ActiveAdmin. It would still be a shame, no?

[a-nickol]

In the past it was the expected behaviour to return status 200 and render :new or :edit templates. But yes with turbo this behaviour is not working anymore.

[tagliala]

Returning a 200 after what is essentially a failed request could be seen as a bug.

I do agree

I would think that a solution that properly works with Turbo is important.

This is still not clear for me. Since Active Admin has its own js file and does not support turbo, I don't know how turbo is being enabled in Active Admin. My guesses are
A. Navigating from the application to the admin area without turbo: false?
B. Application JS is being loaded inside the admin area?
C. Other?

I used to add data-turbo: false all over the place.

This makes me think to Scenario A, but I'm not sure why it should be all over the place

About Scenario B, I don't know if it is a good practice to load application JS inside the admin Area