Comments (4)
@ibalosh and I struggled a bit with how to export the types while we were building out this update.
To your first question, about whether use the wildcard for imports or destructuring it, I think it's personal preference.
Personally, I prefer destructuring the import as it reduces repeating the namespace in the code.
Part of the reason the models are in a separate namespace is to create some separation between the "important" classes (ServerClient, AccountClient, Callback), and all the supporting models. But it does feel a bit clumsy. We'll review this again, and make revisions as necessary.
Also note that we tried to define classes for any object that we expect a user of the library to instantiate (making it easier to provide required parameters, and take advantage of type inference.), and we used interfaces for any results from API responses (these would never be directly instantiated by a consumer of this client).
And you're very welcome for the 2.0 update. We have wanted to move to TypeScript and get the benefits of having the type system in place for a long time, so I'm happy to see you're excited to use it.
from postmark.js.
We have released 2.1 this morning, which addresses some of these issues. Given how important the common classes of Message
, Attachment
, Headers
, TemplatedMessage
are, these are now exported at the top-level of the module, so that should simplify the common sending case.
For more consistency and better intellisense, we also modified a few of the filter parameter type definitions, which is technically a breaking change from 2.0, but given that 2.0 is < 24 hours old, we feel this is better than bumping it a major version in this case.
Please continue to share your feedback as you update to this version.
from postmark.js.
Thanks for the super quick response time!
It's a lot better to use now, there's only one minor inconsistency that I found out:
declare type TemplatedMessage = Models.TemplateMessage;
depending where you import from, the same model is either TemplatedMessage or TemplateMessage. (Note the 'd' on the first form.)
After that minor nag, I think we can close this one.
from postmark.js.
Hi,
we fixed that inconsistency too in the latest version 2.2.0
from postmark.js.
Related Issues (20)
- Unable to send email template within Cloudflare Worker HOT 4
- Rotate DKIM keys Does not work HOT 2
- Request to improve the typing of template models HOT 2
- Broken wiki link HOT 1
- Option to retry failed queries? HOT 1
- Add support for alternative runtimes like Egde (Axios not functioning in Vercel Edge runtime) HOT 10
- Circle CI: Config may introduce inaccurate build results as it uses npm install over clean install for unit tests HOT 3
- Allow API users to add attachments to email templates HOT 1
- Suggestion: Improve Error reporting for .sendEmailWithTemplate HOT 1
- DeliveryWebhook: MessageId should be MessageID (ID in all caps) HOT 2
- Update axios version HOT 2
- Could we upgrade axios please HOT 1
- (Documentation) Link to .travis.yml not working HOT 1
- Update Axios to fix "Axios Cross-Site Request Forgery Vulnerability" HOT 1
- 4.0 Migration Documentation HOT 1
- getOutboundOverview filters not working HOT 2
- Bump Axios to 1.6.8 to address follow-redirects vulnerability HOT 1
- replace Axios with Fetch API
- Incorrectly typed DomainDetails:SafeToRemoveRevokedKeyFromDNS - is string, should be boolean
- Server-Side Request Forgery in axios
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postmark.js.