Giter Site home page Giter Site logo

Comments (4)

atheken avatar atheken commented on August 16, 2024

@ibalosh and I struggled a bit with how to export the types while we were building out this update.

To your first question, about whether use the wildcard for imports or destructuring it, I think it's personal preference.

Personally, I prefer destructuring the import as it reduces repeating the namespace in the code.

Part of the reason the models are in a separate namespace is to create some separation between the "important" classes (ServerClient, AccountClient, Callback), and all the supporting models. But it does feel a bit clumsy. We'll review this again, and make revisions as necessary.

Also note that we tried to define classes for any object that we expect a user of the library to instantiate (making it easier to provide required parameters, and take advantage of type inference.), and we used interfaces for any results from API responses (these would never be directly instantiated by a consumer of this client).

And you're very welcome for the 2.0 update. We have wanted to move to TypeScript and get the benefits of having the type system in place for a long time, so I'm happy to see you're excited to use it.

from postmark.js.

atheken avatar atheken commented on August 16, 2024

We have released 2.1 this morning, which addresses some of these issues. Given how important the common classes of Message, Attachment, Headers, TemplatedMessage are, these are now exported at the top-level of the module, so that should simplify the common sending case.

For more consistency and better intellisense, we also modified a few of the filter parameter type definitions, which is technically a breaking change from 2.0, but given that 2.0 is < 24 hours old, we feel this is better than bumping it a major version in this case.

Please continue to share your feedback as you update to this version.

from postmark.js.

swftvsn avatar swftvsn commented on August 16, 2024

Thanks for the super quick response time!

It's a lot better to use now, there's only one minor inconsistency that I found out:

declare type TemplatedMessage = Models.TemplateMessage;

depending where you import from, the same model is either TemplatedMessage or TemplateMessage. (Note the 'd' on the first form.)

After that minor nag, I think we can close this one.

from postmark.js.

ibalosh avatar ibalosh commented on August 16, 2024

Hi,

we fixed that inconsistency too in the latest version 2.2.0

from postmark.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.