Comments (6)
It would! But we don't provide support for chipKit boards - Digilent has a staff of people for porting libraries - please post up in the chipkit forums :)
from adafruit-motor-shield-library.
Hi Adafruit - to the best of my knowledge, Digilent isn't porting any
libraries (except for the core libraries that come with the standard
Arduino IDE) - that's being left up to us, the 'community'. I have already
posted an announcement of my efforts to the chipKIT/MPIDE forums.
I will just make my Github repo the permanent home of the version of the
Ada Fruit Motor shield library that works with both AVR and PIC32, if
that's OK with you.
*Brian
On Tue, Oct 9, 2012 at 11:27 AM, Limor Ladyada Fried <
[email protected]> wrote:
It would! But we don't provide support for chipKit boards - Digilent has a
staff of people for porting libraries - please post up in the chipkit
forums :)—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-9268351.
from adafruit-motor-shield-library.
Ah got it - well - if you can make it so it supports both cleanly using #ifdefs and such - ill take a pull request. I thought you were asking me to write the code & we don't have any PIC experts here
from adafruit-motor-shield-library.
Yes! Maybe I'm using Github wrong here - but I was told that you should
always create an issue that describes the problem you are trying to solve
with the pull request, and then refer to that issue in your pull request
text so that when the repo admin does a release, they can say that the
issue was fixed by the merge resulting from the pull request.
In any case, I'll be your PIC32 expert in this case. I have added (using
appropriate #ifdefs) PIC32 support to your library, and have tested it on
AVR and PIC32 and both work properly. So this is just a 'please merge my
code changes into the official repo' rather than a request for you to do
any work. And of course test the merge on AVR to make sure I didn't miss
something.
I will also have an update in the (near-ish) future for you: I discovered a
bug in the microstep sequence (for both AVR and PIC32 - the common code)
that I'll fix and issue another pull-request. But that may not happen for a
couple weeks.
P.S. I had a 2-stepper microstep demo running at the Microchip booth at
MFNY running on a chipKIT UNO32 with your motor shield on top - it ran all
day both days with nary a problem using the updated library.
*Brian
On Tue, Oct 9, 2012 at 1:15 PM, Limor Ladyada Fried <
[email protected]> wrote:
Ah got it - well - if you can make it so it supports both cleanly using
#ifdefs and such - ill take a pull request. I thought you were asking me to
write the code & we don't have any PIC experts here—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-9272859.
from adafruit-motor-shield-library.
OK, issues are usually where people hassle me for bug fixes ;)
i see the pull request now, ill check it out and merge it shortly!
from adafruit-motor-shield-library.
Thanks so much! And it was super awesome to see you guys when you stopped
by the Fubar Labs table and said hi.
Later-
*Brian
On Tue, Oct 9, 2012 at 2:07 PM, Limor Ladyada Fried <
[email protected]> wrote:
OK, issues are usually where people hassle me for bug fixes ;)
i see the pull request now, ill check it out and merge it shortly!—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-9274886.
from adafruit-motor-shield-library.
Related Issues (14)
- Global constructors will setup timers too early HOT 1
- Double Precision Floating point HOT 1
- Incompatible with Arduino Due HOT 1
- AFMotor won't Compile on My iMac OR Windows PC HOT 6
- Warning;There is an artificial index in library of 'Adafruit Motor Shield library'
- THe library is not working with esp8266. Please make it compatiable with ESP8266. Thanks HOT 1
- Convert examples from .pde to .ino HOT 1
- artificial index? HOT 1
- Error: "AF_Stepper" does not name a type HOT 7
- False .github in libraries (help) HOT 2
- Error: no member named 'setMinPulseWidth' HOT 4
- onestep() optimization HOT 1
- Incompatible with Leonardo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adafruit-motor-shield-library.