Giter Site home page Giter Site logo

Comments (4)

ladyada avatar ladyada commented on September 2, 2024

hiya, wontfix - this is 100% the standard operation procedure for arduino libaries and we've done it 200+ times for 10 years. Wire.begin() should be idempotent in the board support implementation, as it is in all official Arduino boards!

from adafruit_sgp30.

ladyada avatar ladyada commented on September 2, 2024

its also what Arduino does for their libraries, in case you think we're doing it wrong ;)
https://github.com/arduino-libraries/Arduino_HTS221/blob/master/src/HTS.cpp#L47

from adafruit_sgp30.

TD-er avatar TD-er commented on September 2, 2024

That doesn't mean it is the right thing to do.

I'm not suggesting you should change it to all, only if you want to consider it for this one and future libraries.
If not, then other projects cannot use your libraries by linking to them but have to include them in a patched form.

from adafruit_sgp30.

ladyada avatar ladyada commented on September 2, 2024

nope, wontfix - if you have a 'fork' and its not compatible with arduino's official libraries, its your fork thats the issue :) Wire.begin() was designed to be callable as many times as you like, if that implementation is broken, it needs to be fixed, not a decade worth of libraries

from adafruit_sgp30.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.