Giter Site home page Giter Site logo

Comments (9)

daisylb avatar daisylb commented on August 18, 2024

What version of fish are you running?

from virtualfish.

christophlingg avatar christophlingg commented on August 18, 2024

fish, version 1.23.1

from virtualfish.

fabiant7t avatar fabiant7t commented on August 18, 2024

@christophlingg I was running into the same problem - You can upgrade to fish 2.x (http://fishshell.com/) to solve it.

from virtualfish.

daisylb avatar daisylb commented on August 18, 2024

Thought that might be the case; I might pop a note about Fish versions on the readme before I close this issue.

Fabian Topfstedt [email protected] wrote:

@christophlingg I was running into the same problem - You can upgrade
to fish 2.x (http://fishshell.com/) to solve it.


Reply to this email directly or view it on GitHub:
#14 (comment)

Sent from my phone

from virtualfish.

christophlingg avatar christophlingg commented on August 18, 2024

thanks you guys! i am just updating ...

from virtualfish.

fabiant7t avatar fabiant7t commented on August 18, 2024

@adambrenecki I guess a lot of people ran and will run into the issue, since e.g. Ubuntu 12.04 LTS ships fish 1.x. If @christophlingg's change makes virtualfish work properly on fish 1.x, I'd rather check if fish --version starts with fish, version 1. and use his line then instead of making everyone upgrade fish?!

from virtualfish.

daisylb avatar daisylb commented on August 18, 2024

I haven't actually run it, but I'm 99% sure that change will break subcommands that take more than 1 argument.

Fabian Topfstedt [email protected] wrote:

@adambrenecki I guess a lot of people ran and will run into the issue,
since e.g. Ubuntu 12.04 LTS ships fish 1.x. If @christophlingg's change
makes virtualfish work properly on fish 1.x, I'd rather check if fish --version starts with fish, version 1. and use his line then instead
of making everyone upgrade fish?!


Reply to this email directly or view it on GitHub:
#14 (comment)

Sent from my phone

from virtualfish.

justinmayer avatar justinmayer commented on August 18, 2024

I don't think supporting fish 1.x should be a goal — the differences between it and 2.x are very significant.

Plus, since there is now an official PPA, it is very easy to install the latest fish 2.x release on Ubuntu 12.04 LTS.

from virtualfish.

daisylb avatar daisylb commented on August 18, 2024

I agree. Thanks for the PPA tip, by the way - I've added a link to it in the readme.

from virtualfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.