Giter Site home page Giter Site logo

Comments (10)

adamjarling avatar adamjarling commented on August 23, 2024

@CourtneyMcClellan I'm able to pull in the new stamps ok. The easiest scenario would be if all the stamps are SVG files, as you've sent over, instead of using other image file types, at least for the Stamp feature. So basically whatever you sent over works.

One thought, maybe these should be transparent SVG files?

image

from loc-speculative-annotations.

CourtneyMcClellan avatar CourtneyMcClellan commented on August 23, 2024

Try these for the transparent SVG file:

https://drive.google.com/file/d/1IlAGUVLg5s-z8j4z6VT3ekPFQZdBQ2OZ/view?usp=sharing

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

@CourtneyMcClellan Confirmed this way of saving the SVG is transparent on the canvas:

image

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Update February 2, 2021

New stamp graphics have been added for all colors. This is not a feature to be tested during User Testing round 1 though, so pushing back priority.

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Messages brought over from a Slack conversation...

Adam
If I try to open an SVG file in Illustrator, it asks me to manually select the linked file. I'm kinda out of my element here:)

Courtney McClellan 5:39 PM
SVG files are new to Olivia and myself so we are figuring it out as we go. We will sort it out

Adam J. Arling 5:39 PM
Transparent PNG files would work great too, for web delivery.

Courtney McClellan 5:40 PM
Ok, that may be easier

Adam J. Arling 5:40 PM
With 100+ images (that we'll have to pre-load) I'd recommend the smallest file size you can arrive at for each stamp image. SVG might...not totally sure, be the most compressed? It looks like FabricJS understands both. PNGs seem a little more straightforward, but apparently I figured out a way to make FabricJS understand SVG images as well when you sent me the sample:).

Courtney McClellan 5:43 PM
Ok, if PNG files are better, we may switch to that. I am going to reach out to Olivia and take a look too

Adam J. Arling 5:45 PM
And for prepping the files, in terms of a naming convention, it'd be awesome and save me a bunch of time if you could use the color in the filename. For example: green-star.png or pastelBlue-question-mark.png etc.

Courtney McClellan 5:46 PM
Ok, we can definitely do that! Any notes you have like that bring them on! I am happy to notate in any way that helps

Adam J. Arling 5:47 PM
The current colors which I'm basing off of Jess's pen weight graphics are:

  • green
  • pastelBlue
  • pastelGreen
  • pastelPurple
  • pink
  • teal
  • yellow

@CourtneyMcClellan

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Maybe a fill PNG image file with a color solution here? https://stackoverflow.com/questions/44859026/how-to-select-a-color-fill-it-into-the-selected-image-that-is-uploaded-in-the-c

http://fabricjs.com/image-filters

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

@CourtneyMcClellan So it looks like I am able to update the color of a PNG stamp file through FabricJS. Can you just have Olivia create one color versions of each shape, when you arrive at the final shapes? I'd make the PNG image files either black or white.

from loc-speculative-annotations.

CourtneyMcClellan avatar CourtneyMcClellan commented on August 23, 2024

Great! Ok, will do.

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

So, turns out SVG files are way easier to handle with the dynamic color switching, in both the Options toolbar, and when adding the Stamp file to the Fabric canvas. I was able to convert a few of the black PNG files to SVGs in Illustrator, and here's a start on the work:

image

Note for some reason the Speech Bubble stamp is not respecting the selected color... I'll figure out why over the weekend, and continue building out the rest of the stamps.

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Now updated with all stamps and worked out the bugs. Closing.

from loc-speculative-annotations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.