Giter Site home page Giter Site logo

Comments (8)

adamjarling avatar adamjarling commented on August 23, 2024 1

Correct, not yet implemented. Since we're limiting how a user can move a Work around the OpenSeadragon viewer, I was running into problems getting the initial top margins consistent, per Work. I'll revisit this.

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

@jessvu So I have this now working where the image and canvas will render zoomed out 100%, and are static.

OSD offers a configuration option visibilityRatio (https://openseadragon.github.io/docs/OpenSeadragon.html#.Options) which essentially tells OSD how much of the image needs to stay inside the bounds of OSD's canvas. By default the value is 0.5, allowing a user to pan to the greatest level, only see half the image in the OSD canvas.

I updated this setting to 1, which tells OSD to keep the entire image constrained within the canvas. Along with some other default zoom settings, I was able to get the image to display with some perceived margins around all edges of the image.

However, because we're looking at this from a laptop viewport (I assume....desktop may be different), the viewport is wider than tall, and there are no issues showing extra horizontal padding until a very zoomed-in level. This means that horizontal padding is disabled, until a zoom level is reached where the image zoom level is wider than current canvas. Maybe this is fine...to me it seems a little odd that I can pan vertically but not horizontally until a certain point, but my bias is I'm used to looking at deep zoom image viewers more than the average person.

So...I'll push up the changes and let me know yea/nea?

image

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Actually still working on this. I'll ping you when it's pushed live @jessvu

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Ok, just pushed the changes.

from loc-speculative-annotations.

adamjarling avatar adamjarling commented on August 23, 2024

Just noticed the original size of the image on the canvas (for tall items), doesn't have top/bottom margin. Need to figure out a better way to display the initial image size with margins all around, and (I think) set a dynamic minimum Zoom level in OpenSeadragon each time a new image is loaded into the Viewer.

from loc-speculative-annotations.

jaimemears avatar jaimemears commented on August 23, 2024

The top/bottom margin has not been implemented, correct? (Doing backlog cleanup)

from loc-speculative-annotations.

jaimemears avatar jaimemears commented on August 23, 2024

@adamjarling I noticed with the return to a more "moveable" item in open sea dragon the margins have gone away. Is this an either/or situation? Meaning you cant have top and bottom margins and a moveable item simultaneously?

from loc-speculative-annotations.

jaimemears avatar jaimemears commented on August 23, 2024

@adamjarling nvm! the items look centered in this newest push. Closing this ticket.

from loc-speculative-annotations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.