Add Config Option to Append Client ID & Secret to Request URLs

[adamwathan]

Add Config Option to Append Client ID & Secret to Request URLs

[adamwathan]

Is there any disadvantage to just doing it all the time automatically? If not I'd be happy to just update the provider to always append that info.

Got any reference for me to check out or anything? Thanks man!

[mikebronner]

Turns out GitHub doesn't like what I was doing: adding client_id/client_secret as well as access_token to the query string. They want either the client_id and client_secret for making generic requests that don't need user authentication for you app, or they want the application token for the user you are making requests on behalf of, but not both.

I will have to rethink the strategy here. It may be best left to implement it manually outside of the package. Or perhaps something like this: if there is no access_token in the query string, append client_id and client_secret, if they are set in the config file. That way the user will get the higher api request limit (default is 60 when not logged in, if using access_token or client_id/client_secret you get 5000 per hour).