Giter Site home page Giter Site logo

Comments (6)

adamwathan avatar adamwathan commented on June 2, 2024

Hey Tom, yeah I would love to get a pull request for Twitter support. I know their API works a lot differently than standard OAuth2 providers (I believe the API is OAuth1 and they have some bastardized OAuth2-ish API just for authentication?) so it's definitely going to be a bit of a special case and a bit more work than the other providers.

In regards to the email thing, I think what I would do is just leave the email field in the UserDetails object as null, and leave it up to the person using the package to decide if they need the user's email, and then implement something in their app to deal with it separately. What you've suggested is definitely a valid way that someone could go about implementing it. I don't think this package needs to be concerned with solving that problem directly though, so I think just returning a null email address for Twitter auth and adding a note to the docs mentioning that Twitter doesn't give you an email address would be enough.

So yeah, cook up a pull request if you like, would love to get Twitter support going!

from eloquent-oauth.

adamwathan avatar adamwathan commented on June 2, 2024

Just an update, planning on adding a dependency on the Laravel Socialite package for the next version which will give us Twitter support right out of the box. Hopefully some time in the next few weeks.

from eloquent-oauth.

abhimanyu003 avatar abhimanyu003 commented on June 2, 2024

+1 Yes Laravel Socialite as dependency would be great

from eloquent-oauth.

degrovejazz avatar degrovejazz commented on June 2, 2024

I'm working on an app in Laravel 5 and wanted to use Socialite but found this package much easier to use. Only thing missing is the Twitter auth, which would be great. Thanks for the work on this package!

from eloquent-oauth.

JonathanBruce avatar JonathanBruce commented on June 2, 2024

+1 This package is great, thanks so much. Can't wait for twitter support.

from eloquent-oauth.

prio101 avatar prio101 commented on June 2, 2024

cant wait for twiiter support

from eloquent-oauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.