Error login with multiple providers

[adamwathan]

Error login with multiple providers

[VasquezSRE]

Hello, Is there any way you can have two suppliers for the same user?

[adamwathan]

Hey, unfortunately this isn't supported automatically yet. It's also not a good idea to rely on the email address provided by Facebook/GitHub to determine if two users are the same.

More details on that here: #19

It sounds like you are saving the email like this, yeah?

OAuth::login('github', function ($user, $details) {
    $user->email = $details->email;
    $user->save();
});

Since you can't guarantee uniqueness of emails from third-parties and you can't guarantee two third party users are really the same user based on email, you either need to remove the unique constraint (guessing this is not an option and you are providing email/password login as well) or save the email to a different column or table. Maybe a contact_email column that has no unique constraint.

Then implement a mutator on your User class that looks something like:

public function getEmailAttribute()
{
    return $this->attributes['email'] ?: $this->attributes['contact_email'];
}

...or check the oauth_identities table explicitly if you'd like to confirm the user definitely came from a third party source and their email is stored somewhere else.

I'm considering adding the ability to link an existing third party account with a new third party account, so if you login with GitHub, you could click a link that says "link with Facebook" so you could then login with either option. Trying to support connecting two existing accounts however is beyond the scope of this project, because it involves combining all sorts of existing data that will be specific to your app. Like if you are building a Reddit type of app, I can't possibly know how to assign all of one user's comments to another user, because this package knows nothing about comments. Maybe I can come up with a decent API for getting that process started and leave the data merging to the implementer but I'll have to think about it.

[dhruba-sarma]

A simple solution might help others.....

In core package root directory Authenticator.php return the user in callback like bellow

if ($callback) {
       $user = $callback($user, $userDetails);
 }

and in your application

OAuth::login($provider, function ($user, $details) {
   $exist = User::where('email', $details->email)->first();
     if($exist){
         $user = $exist;
     }
    $user->email = $details->email;
   return $user;
});

You got the idea It works for me .... Thank you
pn: $provider (facebook, google, or github)

[adamwathan]

@dhruba-sarma Yeah I was thinking that as well, great idea. Going to get that in the next release.