External vim editor on windows

[adamyg]

External vim editor on windows

[adamyg]

target build-221

[adamyg]

Build-222 pending

[adamyg]

Further work required to quote args

[silverqx]

I have tested it, and now the generated command doesn't contain /C, but when the file contains whitespace it fails, the generated command looks like this:

vim E:/some dir/file.txt

So it opens empty file, still doesn't work correctly, it has to be quoted when it contains dangerous characters. @adamyg

[silverqx]

Yesterday, before I had gone to the bed, I have little looked at source code on GitHub ( not in an ide, so it might not be accurate ) and it looks like the file paths are passed without quotations for win and also for UNIX systems, on UNIX it works without problems. ( I checked this on my Gentoo install, but I will not describe it here ).

The call chain I have find out is edit_cmd() -> do_edit() -> edit_file_at_line() -> execute_external_editor_or_viewer() ... -> w32_shell(), ..., the path what_vpath which is obtained by fname = vfs_path_from_str (selection (current_panel)->fname); here is unquoted.

This path should be quoted somewhere around execute_external_editor_or_viewer(), I practically don't know anything about mc source code and it was 15min lookup to source code on github, so I can still be wrong. 🙂🤙 @adamyg

[eugenov]

At least I was able to set Notepad3 as external editor with env variable EDITOR. It works as it should.

[eugenov]

Maybe does one know how to let mc open multiple files with external editor? Now mc panels are blocked (black screen) when file is opened with editor. Something like "&" at the end of command...

[adamyg]

Neither options are currently available; open an enhancement ticket and i'll consider