Comments (3)
Fair points! I added a fallback and more descriptive warning message.
I also believe that this breaking change should be mentioned in the release notes for v0.2.0 it it's intentional.
This isn't something that was introduced in 0.2.0. I believe you just happened to stumble on it at 0.2.0.
from complgen.
Thanks for the quick fix!
Fair points! I added a fallback and more descriptive warning message.
The new solution still isn't ideal. complgen will at least compile from release archives, but having the fallback version be literally "fallback" is bad. Package maintainers will have to patch out this logic if they would want to provide a more sensible package version themselves. I am not familiar with the Cargo build system, but I believe it could be possible to use the project's Cargo version as fallback. If the Cargo version is accurate (which might not be the case), this would still provide accurate version information even in environments where git
cannot be used.
If that isn't possible, it would be nice if there was at least a way to override the version without patching the code.
I also believe that this breaking change should be mentioned in the release notes for v0.2.0 it it's intentional.
This isn't something that was introduced in 0.2.0. I believe you just happened to stumble on it at 0.2.0.
This issue is not present in the v0.1.8 release.
from complgen.
Added the fallback to CARGO_PKG_VERSION
👍
from complgen.
Related Issues (20)
- Eliminate redundant edges for subwords in DOT output
- Friendlier parsing error messages
- `complgen scrape` should output grammars using the "distributive descriptions" feature
- [bash] Words containing a colon not completed correctly HOT 2
- Bash integration not working for `--color=(always|never)` HOT 9
- zsh completion doesn't add space after choose a word HOT 4
- usage/complgen.usage is producing warnings HOT 2
- Completion for ZSH doesn't work in default path HOT 7
- Warning: Final DFA contains ambiguous transitions
- Bash: Respect `completion-ignore-case` readline setting
- JIT: Execute external command lazily based on the fallbacks order
- Implement fallback completions (`||`) in AOT mode
- Milestone: Rough feature parity with `git-completion.bash`
- There seems to be a discrepancy between the docs and the runtime HOT 4
- [FR] <PATH> behaviour inconsistent with non-complgen path completion HOT 4
- how to use external command to generate a list of available values with decriptions HOT 3
- Unable to use subword completion HOT 7
- Tag v0.2.0 doesn't update Cargo version HOT 1
- Representing multiple exclusive words separated by , HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from complgen.