Comments (4)
I'm in favor of creating the __init__.py
files, I just don't really like the current naming. What about --init-package
with a default value of True?
Furthermore, the option should be available on the command line as well as in the input configuration file (yml). Plus it should be documented and tested.
@ZanSara would you like to work on this one or shall I assign to myself?
from pyqt5ac.
That's a very small modification to do, so I can do it (docs & tests included ofc), but I would wait for a clarification on the tests issue before submitting more PRs (see #22). For the naming I don't mind, I'll use --init-package
then.
from pyqt5ac.
ok, thanks! I assign to you then.
Regarding the tests, I think the following test cases should be considered:
__init__.py
is generated by default in output directory__init__.py
generation can be disabled__init__.py
is not re-created if already exists
Currently we don't test the command line interface itself but rather invoke the module's main method. So it's okay if you follow the same approach.
from pyqt5ac.
1.2.0 was released. Thanks a lot!
from pyqt5ac.
Related Issues (20)
- Set up auto publication to Pypi repository HOT 5
- Set up CI on GitLab
- Write functional tests
- More robust check for regeneration [WIP] HOT 2
- Update deprecated yaml loading
- Deprecate json usage
- Fail execution if file generation fails
- Set up webhook to GitLab mirror repository HOT 7
- Set up codeclimate integration HOT 3
- Introduce dependency scopes in setup.py HOT 3
- Tests seems to be not independent HOT 2
- Typing HOT 1
- Custom variables not supported from CLI HOT 3
- Introduce tests for CLI
- Auto-detect configuration files HOT 1
- Configurable logging levels
- Paths are not relative to the configuration file HOT 1
- "Bad file descriptor error" from 'click\_winconsole.py' HOT 3
- shlex.split hangs if rcc_options is defined by empty in YAML config
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyqt5ac.