Giter Site home page Giter Site logo

Comments (4)

zkovari avatar zkovari commented on June 2, 2024

I'm in favor of creating the __init__.py files, I just don't really like the current naming. What about --init-package with a default value of True?

Furthermore, the option should be available on the command line as well as in the input configuration file (yml). Plus it should be documented and tested.

@ZanSara would you like to work on this one or shall I assign to myself?

from pyqt5ac.

ZanSara avatar ZanSara commented on June 2, 2024

That's a very small modification to do, so I can do it (docs & tests included ofc), but I would wait for a clarification on the tests issue before submitting more PRs (see #22). For the naming I don't mind, I'll use --init-package then.

from pyqt5ac.

zkovari avatar zkovari commented on June 2, 2024

ok, thanks! I assign to you then.

Regarding the tests, I think the following test cases should be considered:

  • __init__.py is generated by default in output directory
  • __init__.py generation can be disabled
  • __init__.py is not re-created if already exists

Currently we don't test the command line interface itself but rather invoke the module's main method. So it's okay if you follow the same approach.

from pyqt5ac.

zkovari avatar zkovari commented on June 2, 2024

1.2.0 was released. Thanks a lot!

from pyqt5ac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.