Multi Threading | Sidekiq

[adelevie]

Multi Threading | Sidekiq

[ericcj]

a singleton is by no means required and it should be a pretty simple refactor to make Query, Object, etc. buildable via Parse::Client.new.query("ClassName"), having them memoize their @client as a member instead of using the singleton Parse.client and/or let you pass a client into their #get/#save methods.

that's an easy fix that someone should just implement. long term the singleton behavior might actually provide a benefit in the case where the client could manage pooling connections for you via faraday if we could get #88 merged

[cpjolicoeur]

👍 This is becoming a frequent issue for people who use tools like sidekiq. Would love to see this updated to be threadsafe

[fuJiin]

👍 What's the status on the merge?

[adelevie]

Not sure exactly. Anyone want to step up and test this/ensure adequate test coverage?

[kwent]

Same issue there ! That suxxx !

[FilipeAraujo]

same here, any news about this issue?

[jdubs]

Hi, is there an update on this issue?

[FilipeAraujo]

Hi, to workaround this issue I used the following git and branch:

• git => git://github.com/chytreg/parse-ruby-client.git
• branch => feature/faraday-client

Hope this helps.

[adelevie]

This would require a hefty refactoring that I don't have time to implement. I'd be happy to merge in a PR.

[ericcj]

@adelevie #123 should be merged and this and #88 should be closed when you cut a new version of the gem

[adelevie]

Thanks!

[adelevie]

@ericcj what version do you want the newly-cut gem to be?

[ericcj]

0.3 is fine

On Thu, Jul 31, 2014 at 10:06 AM, Alan deLevie [email protected]
wrote:

@ericcj https://github.com/ericcj what version do you want the
newly-cut gem to be?

—
Reply to this email directly or view it on GitHub
#104 (comment)
.

[adelevie]

0.3.0 is released with @chytreg's excellent PR: https://rubygems.org/gems/parse-ruby-client.

Many thanks to @chytreg and everyone else who has helped move this along.

[ericcj]

@adelevie to make master green you should probably remove 1.9.2 testing from the travis.yml. i have no idea why it always fails and everything else always succeeds

[adelevie]

good call. done:
9678d29

On Thu, Jul 31, 2014 at 10:54 AM, Eric Jensen [email protected]
wrote:

@adelevie https://github.com/adelevie to make master green you should
probably remove 1.9.2 testing from the travis.yml. i have no idea why it
always fails and everything else always succeeds

—
Reply to this email directly or view it on GitHub
#104 (comment)
.

[rhymes]

Can you guys please take a look at #165 ?