Comments (7)
Another thought on this: it might also be worth refactoring to place inputs outside of labels, and use for
attributes. Screenreaders often perform better with this explicit style.
from ember-validated-form.
Thanks for your hint @jacob-financeit! I'll have refresh my web a11y knowhow a little to implement this with confidence, so any hints and contributions are more than welcome 😊
from ember-validated-form.
Sorry, I was away for a bit. I think you can use Ember.guidFor() to make sure the label is associated with the right input
from ember-validated-form.
Hi @jacob-financeit, thanks again for you input. I realized that most of our form components are already using the for
attribute instead of wrapped labels, but they were missing the corresponding id
attribute. I created #51 with a quick fix for selects and simple input fields, but obviously that's just a start.
Using for
with radios or checkboxes seems to break the positioning when using bootstrap, and I also couldn't find any clear evidence that the wrapping is really bad for a11y (see e.g. this thread on SO). Do you know more on that?
from ember-validated-form.
No, that's why I phrased it as a 'might'... it's more explicit, and more normative, which usually helps screenreaders (and has been good for i.e. specific versions of NVDA in the past), but it's not a totally unambiguous thing. (That's also why I haven't devoted work time to it yet, because there are bigger / easier wins in other areas of my current project.)
For instance, one thing our QA pointed out is that validation messages are not read by i.e. VoiceOver. I am looking at making them ARIA live regions, so an update to a validation message will trigger it to be vocalized.
from ember-validated-form.
Alright, that makes sense. Proper id
attributes on all form elements is probably one of these quick wins - hopefully we can make some progress on this soon.
from ember-validated-form.
🎉 This issue has been resolved in version 6.2.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from ember-validated-form.
Related Issues (20)
- Optional instead of required
- Dummy app is not loading HOT 1
- Configuration in config/environment.js not working? HOT 4
- TODO: Migrate from ember-i18n to ember-intl HOT 1
- Bootstrap classes not generating HOT 5
- queue is not a helper HOT 1
- Fails to build with embroider
- type=number additional properties HOT 1
- v1 version does not honor previous locale setting of ember-intl HOT 1
- Errors aren't being updated HOT 3
- Release v3.0.3? HOT 2
- Submit event missing event and sender parameters
- Documentation page unusable ("htmlsafe is not a function")
- Cleanup after embroider fixes HOT 1
- Docs are busted HOT 2
- Nested properties not validating (solved) HOT 1
- Help needed to use "on" modifier with <ValidatedInput /> HOT 2
- Adding custom inputs
- Embroider Support is broken HOT 1
- Master is incompatible with node < 18 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-validated-form.