Giter Site home page Giter Site logo

Comments (5)

AdnanHodzic avatar AdnanHodzic commented on May 27, 2024

Hi, since you made a suggestion for how to potentially fix this issue, I would encourage you to please give it a try and create a PR/contribute to the project and you will be credited for your work as part of future release.

from auto-cpufreq.

stkw0 avatar stkw0 commented on May 27, 2024

Thank you. Unfortunately there are some things I am not sure about how to fix it and I don't have enough baggage to do it. For example I see that now the systemd service use a virtual environment installed in /opt. From the point of view of Linux distributions installing installing such a virtual environment is undesirable, but I don't know the reasoning behind that.

from auto-cpufreq.

AdnanHodzic avatar AdnanHodzic commented on May 27, 2024

For example I see that now the systemd service use a virtual environment installed in /opt. From the point of view of Linux distributions installing installing such a virtual environment is undesirable, but I don't know the reasoning behind that.

As someone who used to be a Debian package maintainer and don't see a problem with this approach, I would like to hear why is this undesirable?

For reasoning and logic you can refer to following PR's: #326, #263 & original bug report #196

from auto-cpufreq.

stkw0 avatar stkw0 commented on May 27, 2024

Probably you already know it, but to summarize, having a virtual env installed in /opt is as good as having bundled dependencies. It has security implications and makes it harder to update the package and his dependencies. Each linux distribution has its's own document where they usually reiterate that this things should be avoided, eg: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies

from auto-cpufreq.

AdnanHodzic avatar AdnanHodzic commented on May 27, 2024

This is a design decision that will not change from my side.

If you want to make these changes please give it a try and contribute to the project and you will be credited for your work as part of future release.

In meantime closing the issue.

from auto-cpufreq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.