Issue34 class loader tests fail in github actions but not locally

[adobe]

Issue34 class loader tests fail in github actions but not locally

[baubakg]

It seems that the test itself was activating a classloader which caused the issue. The failed code was:

@Test
    public void testIssue34ManualLoading_case2()  {
        ConfigValueHandlerIBS.INTEGRITY_PACKAGE_INJECTION_MODE.activate("manual");
        ConfigValueHandlerIBS.DEFAULT_CALL_TIMEOUT.activate("60000");
        ConfigValueHandlerIBS.STATIC_INTEGRITY_PACKAGES.activate(MiddleManClassFactory.class.getPackageName()+","+MiddleMan.class.getPackageName());

        JavaCalls l_myJavaCalls = new JavaCalls();

        //Call 1
        CallContent l_cc1 = new CallContent();
        l_cc1.setClassName(CalledClass1.class.getTypeName());
        l_cc1.setMethodName("calledMethod");
        l_myJavaCalls.getCallContent().put("call1", l_cc1);

        //Call 2
        CallContent l_cc2 = new CallContent();
        l_cc2.setClassName(CalledClass2.class.getTypeName());
        l_cc2.setMethodName("calledMethod");
        l_myJavaCalls.getCallContent().put("call2", l_cc2);

        //Setting paths

        l_myJavaCalls.submitCalls();
        assertThat("The called class should be loaded.", l_myJavaCalls.getLocalClassLoader().isClassLoaded(CalledClass1.class.getTypeName()));
        assertThat("The MiddleMan class should be loaded.", l_myJavaCalls.getLocalClassLoader().isClassLoaded(MiddleMan.class.getTypeName()));
        assertThat("The MiddleManFactory class should be loaded.", l_myJavaCalls.getLocalClassLoader().isClassLoaded(MiddleManClassFactory.class.getTypeName()));

    }

Oddly enough it was failing at line 223 which corresponds to:
ConfigValueHandlerIBS.STATIC_INTEGRITY_PACKAGES.activate(MiddleManClassFactory.class.getPackageName()+","+MiddleMan.class.getPackageName());

I.e. before actial execution.

Conclusion

By using structures like MiddleManClassFactory.class.getPackageName() we are actually activating a classloader.

Solution

Use strings

@Test
    public void testIssue34ManualLoading_case2()  {
        ConfigValueHandlerIBS.INTEGRITY_PACKAGE_INJECTION_MODE.activate("manual");
        ConfigValueHandlerIBS.STATIC_INTEGRITY_PACKAGES.activate("com.adobe.campaign.tests.bridge.testdata.issue34.pckg2.,com.adobe.campaign.tests.bridge.testdata.issue34.pckg1.");