Comments (7)
no, I did not touch this part of the addon
from ember-cli-ifa.
@sebastianhelbig why you have empty prepend
in this case? It should be /
if it is a root path, or something else if it's not root in your case.
Would be good to know your use-case in more detail, why prepend is ''
for you?
from ember-cli-ifa.
I use empty prepend, because I have the following problem.
I have image urls stored in models. These images get manually inserted in an image like component.
url: '/images/aabb'
…
this.$().append(`<img src="${model.url}">`);
With disabled fingerprintig this works perfectly. With enabled fingerprinting and non-empty prepend the prepend will be added additionally, so the url will be '//images/aabb', which does not load the image.
Btw: The default prepend is also ''
according to https://ember-cli.com/user-guide/#fingerprinting-and-cdn-urls
from ember-cli-ifa.
we're also having issues with this. the prepend
option does not necessarily make sense. if IFA is disabled, its more than likely that whatever was prepended to the asset paths will still need to be there.
I think it would be better to simply make the path to the assetMap
json file configurable.
Due to the changes removing baseUrl
we're adding a rootUrl
property to all components and controllers:
Having both the prepend
configuration w/ ember-cli-ifa and the changes w/ the rootUrl
in ember-cli are conflicting.
The workaround we are implementing is to add a imageRootUrl
that will check if IFA is enabled or not to apply the rootUrl
or not to avoid duplicating, ala //assets
.
from ember-cli-ifa.
Works in production but not in development with ifa disabled, in development the prepend value is always "/"
from ember-cli-ifa.
@Turbo87 was this one of the issues that you fixed with your recent PR? 🤔
from ember-cli-ifa.
Having the same issue. After looking at the initializer I believe the issue is due to properties on the AssetMap service are not being consistently set across environments. The initializer skips setting the prepend
option if there is no asset-map (i.e. development environment) because it early returns here.
from ember-cli-ifa.
Related Issues (20)
- Use of native fetch causes errors in IE
- Setting ifa enabled:false breaks application HOT 2
- Option for async loading of asset map HOT 1
- Error: ENOENT: no such file or directory, open '/...broccoli_merge_trees/assets/assetMap.js' HOT 1
- Script insertion with contentFor triggers CSP warning HOT 4
- Does fingerprintAssetMap have to be true for inline?
- Having options to remove certain files from the asset map
- Error on 0.6.0, after update HOT 4
- Could not find module `rsvp` imported from `ember-cli-ifa/initializers/asset-map` HOT 1
- Makes request with "undefined" when assetMap.json is not generated and ifa is not enabled in config HOT 4
- assetmap file is loaded through a relative path which fails when you land on a nested route HOT 1
- Fastboot, ifa, and vedor SRI hashes HOT 4
- Add documentation
- Asset map not being added to index.html HOT 7
- Building with --environment=production fails with ENOENT
- vendor.js file MD5 checksum HOT 1
- can master branch be released as 0.8.0 ? HOT 3
- Use dependabot to keep dependencies up-to-date HOT 4
- Your .dependabot/config.yml contained invalid details HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-ifa.