Nothing returned by handler for mockQueryRecord when mocking ember-simple-auth currentUser

[BryanCrotaz]

Nothing returned by handler for mockQueryRecord when mocking ember-simple-auth currentUser

[danielspaniel]

first off .. instead of this >>
let mockPlayer = mockFindRecord('player').returns({model: player});
do this:
let mockPlayer = mockFindRecord(player);

as to this

    mockQueryRecord('user', {current: true}).returns({model: user});

not sure what you doing wrong. you might try using mock instead of mockQueryRecord

https://github.com/danielspaniel/ember-data-factory-guy#mock

but I can't do more than this without actually debugging your code step by step to see why your url not capturing

[BryanCrotaz]

I'm debugging step by step and I've found the handler isn't being matched in requestWrapper.handleRequest.

In request-wrapper.getHandlers, this.handlers == []

[danielspaniel]

Right, so what can I do. I suggested using mock and setting the url exactly ( depending on what the handleRequest url is getting.

you can also check the mock.getURL() function to
see what it is mocking ( mockQueryRequest )

other than that .. you gotta track it down. if its a bug then that is fine but for now I don't know yet

[BryanCrotaz]

what should the handler look like with the test code I wrote? Should handler.handler.handlers be an array of one object?

[BryanCrotaz]

Aha. Found the problem.

    let mockQuery = mockQueryRecord('user', {current: true}).returns({model: user});
    console.log(mockQuery.getUrl());
    //logs /api/v1/users -- should be /api/v1/users/current

[danielspaniel]

there you go .. so simple

[BryanCrotaz]

But the mock is picking up the correct url from my adapter. Can't currently see why it's going wrong

[danielspaniel]

i don't know either frankly .. sorry can't be more help.

[BryanCrotaz]

To check, the handler should pick up the url from the adapter urlForQueryRecord, and then that url should be returned by getUrl?

If that's the correct behaviour I can try to create a failing test with my setup and submit a PR.

[danielspaniel]

i am not 100% sure actually. but factory guy has boat load of tests .. why don't you check there ? if you submit PR with failing test, you will have to fix it yourself as well. Not have time for fixing up things now.

[BryanCrotaz]

Works with ember-data 3.9, fails spectacularly with 437 test failures with ember-data 3.18 (which is what I'm using). Investigating.

[danielspaniel]

yeah , i have not updated factory guy for the latest ember , and since I am not using ember anymore, I am not really into doing that. hope that is not a killer for you trying to fix though

[BryanCrotaz]

Found the problem. Submitting a PR.

[BryanCrotaz]

The failing tests with latest ember-data appear to be a problem with ember-data-model-fragments.

[danielspaniel]

model fragments have not updated in a while, so ? not much we can do i reckon. but thanks for heads up.

[BryanCrotaz]

There is a fix coming in model fragments, a couple of weeks away they say

[BryanCrotaz]

My PR is unrelated to model fragments. It fails in master

[danielspaniel]

what fails in master ? confused, since I just merged your PR since all tests passed in master with it

[BryanCrotaz]

Look at the 1 line code change. There’s a comment with it explaining it. The test I’ve added fails in master but doesn’t fail with the code fix I’ve also supplied.

[BryanCrotaz]

Fixed by #416