Giter Site home page Giter Site logo

Comments (14)

gdams avatar gdams commented on August 10, 2024

I think the API might need some changes to expose this, lets see what @johnoliver thinks

from openjdk-api-v3.

johnoliver avatar johnoliver commented on August 10, 2024

I am not sure what is in the java -version output that is not in the version data
looking at

{
    "WARNING": "THIS METADATA FILE IS STILL IN ALPHA DO NOT USE ME",
    "os": "linux",
    "arch": "x64",
    "variant": "hotspot",
    "version": {
        "minor": 0,
        "full_version_output": "openjdk version \"11.0.8\" 2020-07-14\nOpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+5-202006222334)\nOpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+5-202006222334, mixed mode)\n",
        "security": 8,
        "pre": null,
        "adopt_build_number": 0,
        "major": 11,
        "version": "11.0.8+5-202006222334",
        "semver": "11.0.8+5.0.202006222334",
        "build": 5,
        "opt": "202006222334",
  },
    "scmRef": "",
    "version_data": "jdk11u",
    "binary_type": "jdk",
    "sha256": "dbc32955fc283989f57ef832f3398af0cc7de7b9287256077206bb6e023dc693"
}

It seems like all the data in the full_version_output is also in version

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

It was requested at adoptium/temurin-build#367 that the version output is displayed at the nightly download page

from openjdk-api-v3.

johnoliver avatar johnoliver commented on August 10, 2024

I think the problem is that issue was requesting this to tie back a build to a git commit, I am not sure the output of java -version here allows you to do that. I would have thought a way to do this would be to include the git commit hash into the metadata

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

@johnoliver See existing issue for that adoptium/temurin-build#474

from openjdk-api-v3.

johnoliver avatar johnoliver commented on August 10, 2024

@M-Davies yeah I think that would be the issue to solve as I think that would solve adoptium/temurin-build#367 but I dont believe adding java -version to the metadata does

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

See adoptium/temurin-build#1959

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

Transferring to api repo (see #235 (comment))

from openjdk-api-v3.

johnoliver avatar johnoliver commented on August 10, 2024

we are going to look at adding a link to the metadata file into the api on the Asset, so if the web page wants the version output it can pull that data via that link

from openjdk-api-v3.

nickebbitt avatar nickebbitt commented on August 10, 2024

I've started looking at this

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

@nickebbitt Can this be closed?

from openjdk-api-v3.

nickebbitt avatar nickebbitt commented on August 10, 2024

@karianna this now live so can be closed

from openjdk-api-v3.

M-Davies avatar M-Davies commented on August 10, 2024

See #235 (comment)

from openjdk-api-v3.

karianna avatar karianna commented on August 10, 2024

Opened a website issue for this

from openjdk-api-v3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.