CLANG 9.01 warnings

[adrian-thurston]

CLANG 9.01 warnings

[adrian-thurston]

Hi @mingodad, do the changes you made eliminate all these warnings? If so, I will close the issue.

[mingodad]

Hello Adrian !
No it doesn't, the ones bellow seems to be generated and I didn't identified then to change, in this case it was an arm64 and looking at this forum http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.faqs/ka11308.html they explain this:

There is a difference between a plain char and a signed char. By default a plain char represents an unsigned char value. Using the compiler directive --signed_chars changes the default behaviour of plain char to be a signed char. In µVision this is configured under Project - Options - C/C++ - Plain Char is Signed.

So I think that it would be nice to have this managed transparently between architectures.

/bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../src -I../colm  -I../aapl -I../colm/include -DBINDIR='"/data/data/com.termux/files/home/local/colm/bin"'   -Wall -g -MT libragel_la-parsetree.lo -MD -MP -MF .deps/libragel_la-parsetree.Tpo -c -o libragel_la-parsetree.lo `test -f 'parsetree.cc' || echo './'`parsetree.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../src -I../colm -I../aapl -I../colm/include -DBINDIR=\"/data/data/com.termux/files/home/local/colm/bin\" -Wall -g -MT libragel_la-parsetree.lo -MD -MP -MF .deps/libragel_la-parsetree.Tpo -c parsetree.cc  -fPIC -DPIC -o .libs/libragel_la-parsetree.o
parse.c:7973:20: warning: result of comparison of constant -17 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -17 )
             ~~~~~~~~~~~~ ^  ~~~
parse.c:7980:20: warning: result of comparison of constant -69 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -69 )
             ~~~~~~~~~~~~ ^  ~~~
parse.c:7987:20: warning: result of comparison of constant -65 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -65 )
             ~~~~~~~~~~~~ ^  ~~~
parse.c:8001:20: warning: result of comparison of constant -17 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -17 )
             ~~~~~~~~~~~~ ^  ~~~
parse.c:8008:20: warning: result of comparison of constant -69 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -69 )
             ~~~~~~~~~~~~ ^  ~~~
parse.c:8015:20: warning: result of comparison of constant -65 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
        if ( (*pdaRun->p) == -65 )
             ~~~~~~~~~~~~ ^  ~~~

Cheers !

[adrian-thurston]

Ah, okay. We need to make a configure check and then modify hostTypeC appropriately in main.cc. This should cause the codegen to generate the correct numerical formats.

[mingodad]

It seems that the parser.c comes in a kind of tar file, how to update it, or the source of it to generate a cast or non negative values ?

[adrian-thurston]

The colm parser is bootstrapped, so you can find the code in the *codegen.cc files. I haven't looked at it lately, but it is roughly broken down into scanner, parser, reduction, loading and top level.

The tarball is there because. I am now trying to follow the rule that each makefile rule generates only one output, which simplifies specifying dependencies.

[mingodad]

There is several possible places where it could be generated and with my knowledge of this code base I'm not sure which of then is it.
Could you have a look at it ?

[adrian-thurston]

For sure, I'm not able to until Monday though.

[adrian-thurston]

Last warnings are related to alphabet signedness and really stem from a bigger issue. Need to lock down the alphabet as unsigned char. Closing this one here and the issue lives on in #104