Animations not properly applied when updating text

[adrianmcli]

Animations not properly applied when updating text

[DougLilliequist]

Ok, I worked one solution to my issue, which was to simply clone my child component, update it's props with show = false and it worked! However I'm quite new to react and to me it seems like a quite costly procedure, unless it's a lot more expensive to remove and apply new spans on the fly?

[adrianmcli]

This probably has something to do with the fact that shouldComponentUpdate() always returns false if the show prop hasn't changed. That means that the spans (and their styles) are not being reapplied when you change your text.

It may be a good idea to allow users to opt-in to this optimization. I welcome any PRs for this.

[DougLilliequist]

Okok! So If I just remove that condition, should the component then update with the new spans? And of curiosity, would it be more performant to update a components children(i,e the new spans) than unmounting and rendering a new component?

[adrianmcli]

Try the new version 0.1.1. I made additional checks under shouldComponentUpdate.

[DougLilliequist]

Tried it yesterday and It made my code much simpler, but both my old and new solution with your updated code is making my project hurt in chrome due to a huge composite layer / paint call. I did notice however when running my project in firefox, it runs super smooth!

Other than that, amazing job with this component!

[adrianmcli]

Yeah unfortunately, there's no other way to do this (without using SVG or Canvas). DOM element updates are necessary to apply the spans and that tends to be expensive.