advik-b/cmpdl

Curseforge ModPack Downloader

Hi there 👋

• 🌱 I’m currently learning: C++ programming
• 👯 I’m looking to collaborate on: python-apps ( happy to help! )
• 📫 How to reach me: [email protected]
• 😄 Pronouns: I don't beleve in them (custom pronouns) lol (im a guy)
• ⚡ Fun fact: I LOVE Shawarma

cmpdl's Issues

Make a UI for CMPDL

Cursepy cannot download the correct version of the mod if we use guess_download()

As mentioned #25 when we need to use curspy's guess_download() it sometimes incorrectly downloads the mod file.

i haven't been able yet to figure out what causes the incorrect download.

More Bugs - Need fixes

First one dont close on itself -> cause non Indented block
This one not work because there isnt connect property avail

Also cursepy is updated, you can use new API now without changing code and close #16 as its no longer needed

The download is in html

the .jar file is actually html

[BUG] CurseAPI has been revamp

Curse has changed their API system mean CursePy no longer work
As the solution for now is to implement API direct or wait for update from CursePy
Example: https://github.com/PolyMC/PolyMC/tree/develop/launcher/modplatform/flame

[Linux] Some mods in manifest cause a crash.

CMPDL v2.0.0, CLI interface

I'm downloading All The Mods 7 - To the Sky (modpack version 1.1.6) and some of the mods crash both the cli and gui versions.
My error is as follows

[19:36:32]-[INFO]: Downloading mod 30 out of 226
[19:36:32]-[INFO]: Mod name: Ex Nihilo: Sequentia
[19:36:32]-[INFO]: Mod url: https://www.curseforge.com/minecraft/mc-mods/ex-nihilo-sequentia
[19:36:32]-[INFO]: Mod author(s): (CurseAuthor(id=308637, name='NovaMachina', url='https://www.curseforge.com/members/100810788-novamachina?username=novamachina'),)
[19:36:32]-[INFO]: Mod is required
'NoneType' object has no attribute 'split'
Something went wrong, check the log for more info
If you think this is a bug, please report it on the GitHub page
https://github.com/Advik-B/CMPDL/issues/new
Traceback (most recent call last):
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cli.py", line 233, in <module>
    main()
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cmpdl/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cmpdl/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cmpdl/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cmpdl/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cli.py", line 227, in main
    raise e
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cli.py", line 221, in main
    m.install()
  File "/home/twigglenn4/Downloads/CMPDL-2.0.0/src/cli.py", line 135, in install
    mods_folder, unquote(file.download_url.split("/")[-1])
AttributeError: 'NoneType' object has no attribute 'split'

This occurred for Ex Nihilo: Sequentia and it's addons, so I think it might be related to the colon : in its title.

My current solution is to download the mod from the CurseForge website, copy the project ID from the website, find and remove that entry in the manifest.json, and run the program again.

Modpack .zip file link:
https://www.curseforge.com/minecraft/modpacks/all-the-mods-7-to-the-sky/download/4094716?client=n

Combine `backend.py` and `cli.py` into one file for easy maintanence

Add CLI support

I just found your tool, and it looks really promising. CLI support is like a must-have :P

Revamp the UI

It looks old, and it is NOT consistent, when (force) resizing
I was using tkinter, now I will use PyQt5

[Linux] cli.py results to service unavailable

reproduce

1. download git repo
2. create python venv
3. install requirements
4. run cli normaly with options to file.zip and output

logs

log.txt

expected behaviour

downloading modpack to directory