Invalid return character or leading space in header: User-Agent

[adyen]

Invalid return character or leading space in header: User-Agent

[patvdleer]

So if you leave the app name empty this will cause an error in the requests

class HTTPClient(object):
    def __init__(self, app_name, user_agent_suffix,
                 lib_version, force_request=None):
        # Check if requests already available, default to urllib
        self.user_agent = app_name + " " + user_agent_suffix + lib_version

[AlexandrosMor]

Hello @patvdleer,

Indeed if the appname is empty cause error in the request. Is there a specific reason why the appname should be empty for you ?

kind regards,
Alexandros

[patvdleer]

No I was testing and the params of the function allowed it, why not require the param? The error InvalidHeader which this causes doesn't make it clear you need to set the app name.

The functions before accept empty param while there are actually required down the line.

This seems to be everywhere, take payment_methods for example, request should not be optional, what am I missing? why is this defaulted to an empty string?

class AdyenCheckoutApi(AdyenServiceBase):
    def __init__(self, client=""):
        super(AdyenCheckoutApi, self).__init__(client=client)
        self.service = "Checkout"

    def payment_methods(self, request="", **kwargs):
        action = "paymentMethods"
        if 'merchantAccount' in request:
            if request['merchantAccount'] == '':
                raise ValueError(
                    'merchantAccount must contain the merchant account'
                    ' when retrieving payment methods.')

        return self.client.call_checkout_api(request, action, **kwargs)

[AlexandrosMor]

@patvdleer,
We created an internal issue and we are going to pick it up as soon as possible. For now you can pass a dummy app_name so you can continue with the integration.

regards,