Giter Site home page Giter Site logo

Comments (3)

igorhoogerwoord avatar igorhoogerwoord commented on August 24, 2024

So for Python, class instance attributes do use dot notation, this is expected.
However, any other dicts in class instance attributes must be in normal dict format.

I removed dotdict conversion of 'message' in AdyenResult in both client.py and apiclient.py.

from adyen-python-api-library.

lucasbledsoe avatar lucasbledsoe commented on August 24, 2024

Ultimately, I think this is very semantical situation, if these values were instead stored in a series of objects, suddenly they can be accessed via dot notation and it is ok? Seems like an opinion/usage thing vs an actual problem. This also doesn't prevent normal bracket access of dictionaries. Your example was a class attribute so needs to be accessed via dot notation anyways, which you realized.

I included the ability to access via dot notation for the sake of ease and this is something that exists as a concept in other python libraries as well. In my mind, there is no point in removing a feature unless it does cause a problem.

from adyen-python-api-library.

igorhoogerwoord avatar igorhoogerwoord commented on August 24, 2024

I believe you are correct, if indeed the properties of the AdyenResult class, such as 'message' are both iterable, accessible through bracket notation and directly encodable to JSON it is fine.

My example was indeed incorrect, wrongly referring to the class itself instead of a property.

Closing this issue for now.

from adyen-python-api-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.