Comments (3)
So for Python, class instance attributes do use dot notation, this is expected.
However, any other dicts in class instance attributes must be in normal dict format.
I removed dotdict conversion of 'message' in AdyenResult in both client.py and apiclient.py.
from adyen-python-api-library.
Ultimately, I think this is very semantical situation, if these values were instead stored in a series of objects, suddenly they can be accessed via dot notation and it is ok? Seems like an opinion/usage thing vs an actual problem. This also doesn't prevent normal bracket access of dictionaries. Your example was a class attribute so needs to be accessed via dot notation anyways, which you realized.
I included the ability to access via dot notation for the sake of ease and this is something that exists as a concept in other python libraries as well. In my mind, there is no point in removing a feature unless it does cause a problem.
from adyen-python-api-library.
I believe you are correct, if indeed the properties of the AdyenResult class, such as 'message' are both iterable, accessible through bracket notation and directly encodable to JSON it is fine.
My example was indeed incorrect, wrongly referring to the class itself instead of a property.
Closing this issue for now.
from adyen-python-api-library.
Related Issues (20)
- Client uses incorrect live endpoint URLs for payments HOT 3
- Idempotency support HOT 5
- [PW-3985]Pay By Link support HOT 2
- PaymentCompletionDetails dict HOT 1
- Checkout payment details : error 702 HOT 4
- [PW-4232] Support latest checkout API v67 HOT 4
- Encrypted card details in python HOT 1
- [PW-5864] Support for creating Apple Pay sessions HOT 1
- [PW-5867] HMAC verification functions corrupt notification item payload HOT 2
- [PW-5865] Python support for Local/Cloud-based Terminal API HOT 4
- Client is not following adyen docs about psp reference HOT 4
- Hard to understand the docs HOT 2
- Unnecessary escape_val method being used at generate_notification_sig ?
- PW-6905: is_valid_hmac and is_valid_hmac_notification are vulnerable to timing attack HOT 1
- Requesting release of latest develop branch to leverage refunds fix HOT 2
- PSP reference missing from Adyen result
- Adyen client merchant_account value is ignored when sending API requests HOT 1
- management.payment_methods_merchant_level_api.get_all_payment_methods doesn't accept query parameters HOT 1
- `TerminalsTerminalLevelApi.reassign_terminal` throws JSONDecodeError HOT 1
- is_valid_hmac_notification mutates passed webhook data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adyen-python-api-library.