Comments (9)
from ignoresaccesscheckstogenerator.
I think it already is?
<PropertyGroup>
<InternalsAssemblyNames>Microsoft.CodeAnalysis.Features;Microsoft.CodeAnalysis.Workspaces</InternalsAssemblyNames>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="IgnoresAccessChecksToGenerator" Version="0.1.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build" Version="15.3.0-preview-000388-01" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="2.3.1" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Features" Version="2.3.1" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="2.3.1" />
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="2.3.1" />
<PackageReference Include="RestSharp.NetCore" Version="105.2.4-rc4-24214-01" />
</ItemGroup>
from ignoresaccesscheckstogenerator.
Oh to the InternalsAssemblyNames attribute! just trying now
from ignoresaccesscheckstogenerator.
I meant add it in the InternalsAssemblyNames
. It should be there anyhow since there are base types in there, and the accessibility needs to be the same for it to work properly.
from ignoresaccesscheckstogenerator.
I think I know what the problem is. I'm adding the new reference assemblies without removing the old ones. Perhaps the problem is in the netcoreapp2.0
SDK (which I haven't tested). Anyway it's an easy fix.
from ignoresaccesscheckstogenerator.
@aelij let me know when its ready, and I will test, adding Microsoft.CodeAnalysis didn't change anything.
from ignoresaccesscheckstogenerator.
@aelij gentle reminder to submit fix ;)
from ignoresaccesscheckstogenerator.
@danwalmsley Try now :)
from ignoresaccesscheckstogenerator.
Thanks It seems to work now 👍
from ignoresaccesscheckstogenerator.
Related Issues (13)
- unknown build error HOT 2
- Maybe remove old Generated Assemblys on clean of project/solution HOT 1
- Monodevelop: analyzer uses original reference instead of generated one HOT 2
- Add supports F# HOT 1
- Incremental build issues with IgnoresAccessChecksTo.cs HOT 1
- Suggestion HOT 4
- .NET Core 2 Release giving IgnoresAccessChecksToGenerator.targets(12,5): error MSB4044: The "PublicizeInternals" task was not given a value for the required parameter "AssemblyNames". HOT 1
- Should InternalsAssemblyNames be an MSBuild Item, not a Property? HOT 8
- AssemblyResolutionException when publicizing internals on .Net Framework 4.6 HOT 2
- Does not open access to private methods HOT 5
- Doesn't work with WPF projects HOT 13
- Error "Could not load file or assembly ***" when I use it in console app (but it works in tests project) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ignoresaccesscheckstogenerator.