Giter Site home page Giter Site logo

Comments (9)

aelij avatar aelij commented on August 22, 2024

from ignoresaccesscheckstogenerator.

danwalmsley avatar danwalmsley commented on August 22, 2024

I think it already is?

<PropertyGroup>
    <InternalsAssemblyNames>Microsoft.CodeAnalysis.Features;Microsoft.CodeAnalysis.Workspaces</InternalsAssemblyNames>
  </PropertyGroup>
  
  <ItemGroup>
    <PackageReference Include="IgnoresAccessChecksToGenerator" Version="0.1.0" PrivateAssets="all" />
    <PackageReference Include="Microsoft.Build" Version="15.3.0-preview-000388-01" />
    <PackageReference Include="Microsoft.CodeAnalysis" Version="2.3.1" />
    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Features" Version="2.3.1" />
    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="2.3.1" />
    <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="2.3.1" />
    <PackageReference Include="RestSharp.NetCore" Version="105.2.4-rc4-24214-01" />
  </ItemGroup>

from ignoresaccesscheckstogenerator.

danwalmsley avatar danwalmsley commented on August 22, 2024

Oh to the InternalsAssemblyNames attribute! just trying now

from ignoresaccesscheckstogenerator.

aelij avatar aelij commented on August 22, 2024

I meant add it in the InternalsAssemblyNames. It should be there anyhow since there are base types in there, and the accessibility needs to be the same for it to work properly.

from ignoresaccesscheckstogenerator.

aelij avatar aelij commented on August 22, 2024

I think I know what the problem is. I'm adding the new reference assemblies without removing the old ones. Perhaps the problem is in the netcoreapp2.0 SDK (which I haven't tested). Anyway it's an easy fix.

from ignoresaccesscheckstogenerator.

danwalmsley avatar danwalmsley commented on August 22, 2024

@aelij let me know when its ready, and I will test, adding Microsoft.CodeAnalysis didn't change anything.

from ignoresaccesscheckstogenerator.

danwalmsley avatar danwalmsley commented on August 22, 2024

@aelij gentle reminder to submit fix ;)

from ignoresaccesscheckstogenerator.

aelij avatar aelij commented on August 22, 2024

@danwalmsley Try now :)

from ignoresaccesscheckstogenerator.

danwalmsley avatar danwalmsley commented on August 22, 2024

Thanks It seems to work now 👍

from ignoresaccesscheckstogenerator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.