Adding Typescript definition file to @types repo?

[af]

Adding Typescript definition file to @types repo?

[af]

Hi, I'm not super familiar with Typescript (the envalid definitions are the work of several other contributors). What's the benefit to having the definitions in that repo, rather than here?

[sjmcdowall]

@af -- Basically it's sort of now standard for TS programmers -- when they import a new module to try to do a

yarn add --dev @types/module

to bring in the TS definition file.. it's second nature and if you look at the @types repo there are 1000's of TS definition files there from all sorts of things.

Having it here means someone needs to find it -- and then add it to their actual source tree somewhere and point tsconfig to it .. and .. not just have it in the devDependencies (where it's needed).

So I really think having envalid make a @types/envalid contribution would be great. I could give it a whirl (never added anything to @types myself) if that's ok?

[af]

Sure go for it! If it makes it easier for people to use the library, sounds great to me.

It seems strange to me that Typescript wouldn't also look in the package's repo for type definitions, though 🤷‍♂️

[sjmcdowall]

I was just thinking the same thing actually .. I'm going to explore that and maybe my lack of TS knowledge has me doing something wrong in my tscofnig! :)

[af]

👍 Closing this and looking forward to seeing the definitions added to @types

[sjmcdowall]

Your going to be disappointed because -- after some digging and checking -- it's not needed -- tslint does indeed (with a proper config) look at the node module for adefinition .. doh! Sooooo .. Nevermind ... nothing to see here.. move along :)

[af]

Oh great, thanks for looking into that, it's good to know 👍