Go() hangs if you only check for errors

[afex]

Go() hangs if you only check for errors

[afex]

this is identical to

errors := make(chan error)
go func() {
  // don't push anything to errors
}()
err := <-errors
return err

it is a programming error and not a hystrix problem.

closing.

[keyneston]

I disagree. hystrix.Go should close the channel when it is finished. Signaling that it is done.

This is functionally equivalent to the following go code:

    errors := make(chan error)
    go func() {
        // don't push anything to errors
        err := fun1()
        if err != nil {
            errors <- err
        }
    }()
    err := <-errors
    return err

[afex]

good point. i'll close the channel when the command is done

On Thu, Jan 15, 2015 at 12:41 PM, tarrant [email protected] wrote:

I disagree. hystrix.Go should close the channel when it is finished.
Signaling that it is done.

—
Reply to this email directly or view it on GitHub
#7 (comment).