Crash when running from child fragment

[afollestad]

Crash when running from child fragment

[afollestad]

I think the fix to #13 should fix this as well, let me know if not (release coming soon)

[afollestad]

Huh, I'm having trouble reproducing this on my Pixel 3 with Android Q

[CarsonRedeye]

I'm also getting this crash. When I run runWithPermissions from a Fragment inside a Fragment pager adapter

[CarsonRedeye]

On further investigation it only happens when I upgrade to navigation components 2.1.0-alpha02. This uses the androidx fragments which must cause this bug

[afollestad]

I use AndroidX Fragments and have not observed any problems.

[CarsonRedeye]

Which version? Navigation components currently only depends on androidx.fragment:fragment:1.1.0-alpha05 maybe they fixed it in alpha06 or 07. Could you test with alpha05?

[CarsonRedeye]

To further clarify, Navigation version 1.0.0 works, but Navigation 2.1.0-alpha02 doesn't

[afollestad]

I meant specifically indidual AndroidX Fragments (androidx.app.Fragment), not the dependency there or anything navigation related.

[CarsonRedeye]

Sorry if I wasn't clear. I'm talking about the androidx.app.Fragment also. It has different versions released via jetpack now. I only mentioned Navigation because it internally depends on different versions of fragment. I've narrowed the crash down to happening if you depend on "androidx.fragment:fragment:1.1.0-alpha05" (or alpha06 or alpha07) but it doesn't happen if you depend on implementation "androidx.fragment:fragment:1.1.0-alpha04".

[CarsonRedeye]

Does any of this sounds suspiscious ? https://developer.android.com/jetpack/androidx/releases/fragment#1.1.0-alpha05

[CarsonRedeye]

So the crash is obviously related to the change in fragment alpha05 in the above link.
"Calling remove(), hide(), show(), detach(), and setPrimaryNavigationFragment() with a Fragment attached to a different FragmentManager now throws an IllegalStateException rather than silently failing (aosp/904301)"
I had a look at your code to see if I could make a PR but couldn't see the solution. Looking forward to a fix. Cheers

[guger]

I'm getting the same error when calling it from within a DialogFragment.

java.lang.RuntimeException: Failure delivering result ResultInfo{who=@android:requestPermissions:, request=65596, result=-1, data=Intent { act=android.content.pm.action.REQUEST_PERMISSIONS (has extras) }} to activity {at.guger.moneybook.dev/at.guger.moneybook.ui.activity.MainActivity}: java.lang.IllegalStateException: Cannot detach Fragment attached to a different FragmentManager. Fragment PermissionFragment{e597fd5 (a8933ae6-618e-41cd-be92-64617c72530a) [assent_permission_fragment/fragment]} is already attached to a FragmentManager.

I'm using AndroidX libraries:
Navigation: 2.1.0-alpha03
Fragment: 1.1.0-alpha08

[CarsonRedeye]

Yeah works for me!