Giter Site home page Giter Site logo

Support `diffsplit` in PR about critiq.vim HOT 4 CLOSED

aghost-7 avatar aghost-7 commented on August 22, 2024
Support `diffsplit` in PR

from critiq.vim.

Comments (4)

AGhost-7 avatar AGhost-7 commented on August 22, 2024

To my knowledge, vimdiff only supports diffing one file at a time. Most PRs I review are multiple files.

from critiq.vim.

dzhang-b avatar dzhang-b commented on August 22, 2024

@AGhost-7 yeah, but it can be a queue of files to be reviewed. git difftools does that and it automatically opens the next file to be reviewed if you close the current diffs.

from critiq.vim.

AGhost-7 avatar AGhost-7 commented on August 22, 2024

Personally this isn't how I'd want to review a PR. I scan the whole changes first then look in higher detail each file. I don't think vim diff is going to work.

If you're interested in implementing this I would accept a PR as an opt-in feature (meaning the old behaviour would be the default).

from critiq.vim.

dzhang-b avatar dzhang-b commented on August 22, 2024

@AGhost-7 I found that in diff page I can type gf on the diff content and go to that file. It is very useful and I dont think this feature is needed for now. Thanks!

from critiq.vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.