Giter Site home page Giter Site logo

Comments (8)

kessler-frost avatar kessler-frost commented on September 21, 2024 1

@Andrew-S-Rosen so when creating a new device in Pennylane there are some attributes that the custom device is required to have, essentially describing what are all the operations and observables that this particular device supports as not all devices can physically support all operations/observables. This is why here we are simply making our device support whatever the default device supports. This is why you couldn't find it in the codebase 😅 because it's something that is required by pennylane when defining a custom device.

from covalent.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on September 21, 2024 1

@kessler-frost: Makes perfect sense to me! I was admittedly relying blind on the test suite for this since I don't know anything about pennylane. I'll go ahead and close this!

Edit: Oops, I thought this was a PR. The issue should still be kept open until it's resolved!

from covalent.

kessler-frost avatar kessler-frost commented on September 21, 2024 1

I'd say even your PR should be open 😅 . I can comment on there once it's resolved. Until then you can keep it in draft mode instead I believe.

from covalent.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on September 21, 2024

Looks like this is the offending line:

operations = DefaultQubit.operations

@kessler-frost: Is the QEDevice.operations attribute actually used anywhere? I couldn't spot it from a quick search in the codebase, but maybe I missed it.

from covalent.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on September 21, 2024

@kessler-frost: Ah, that explains it! So then in order to resolve this issue, we basically need to swap out the required attributes (if any) and then would need to pin a lower-bound version on pennylane if I understand correctly.

from covalent.

kessler-frost avatar kessler-frost commented on September 21, 2024

That is correct.

from covalent.

kessler-frost avatar kessler-frost commented on September 21, 2024

Sorry @Andrew-S-Rosen , but I think this issue will be blocked by #1877 😓 . We don't currently have tests enabled for the qelectrons (which are the reason behind the Pennylane dependency), thus we cannot know whether upgrading to version 33 will break the feature or not (or if the feature has gotten broken due to a recent change yet).

from covalent.

Andrew-S-Rosen avatar Andrew-S-Rosen commented on September 21, 2024

Sounds good!!

from covalent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.