Giter Site home page Giter Site logo

Comments (2)

awestendorf avatar awestendorf commented on August 16, 2024

As noted in the comments, the goal is to ensure that the protocol is adhered to while also re-raising the exception. The exceptions that you note should be reraised. Can you provide more detail on when and how that path fails?

from haigha.

vitaly-krugl avatar vitaly-krugl commented on August 16, 2024

Regarding "Spec says that channel should be closed if there's a framing error.", exceptions like SystemExit are not framing errors. SystemExit and friends are specifically not derived from Exception so that applications/libraries will just let them percolate unfettered. As far as I know, we should normally not be catching exceptions that do not inherit from Exception.

from haigha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.