3xx status appear as failure?

[agraboso]

3xx status appear as failure?

[masad-frost]

+1, main problem is 304

[barrystaes]

How could we handle such a redirect.. can fetch() handle this?

If this can be improved in a PR, i'd like to merge in the upcoming 2.0 release.

[nason]

I believe this comes from the use of res.ok here:

redux-api-middleware/src/middleware.js

Lines 147 to 159 in cbf0553

	if (res.ok) {
	return next(await actionWith(successType, [action, getState(), res]));
	} else {
	return next(
	await actionWith(
	{
	...failureType,
	error: true
	},
	[action, getState(), res]
	)
	);
	}

If we make this configurable, this middleware should be able to support use cases like this one.

[nason]

This is being looked at in #171

[nason]

In 2.x, you can now pass a custom fetch implementation
In 3.x (upcoming), you'll be able to pass a custom ok check

I think this should be enough to handle most situations, so I'm going to close this out. Feel free to re-open or continue commenting here though.