Giter Site home page Giter Site logo

Comments (4)

RangerMauve avatar RangerMauve commented on May 22, 2024 2

I think there's two ways we can approach this:

  • Spit the refresh/go button into two buttons (this is what most browsers do)
  • When you de-focus the omni-box, it should revert to whatever the current URL is
  • Something else

from agregore-browser.

KyGost avatar KyGost commented on May 22, 2024 2

I feel like the defocus could be a good solution.
One would need to have a go with it first and see if it feels odd/bad though.

from agregore-browser.

jolindroth avatar jolindroth commented on May 22, 2024

I think we can reuse the custom event from #139. Currently the event is only fired when we press the ESC-button, but if we can make it fire on focusing the BrowserView/WebContents I think we will get the behaviour we want.
May require some workarounds since there's no native support for focus events of BrowserView/WebContents in electron yet: electron/electron#25873

from agregore-browser.

RangerMauve avatar RangerMauve commented on May 22, 2024

I think the UX after @jolindroth 's fix in #139 makes this usable. Basically, after we navigate away the URL bar gets reset so you can reload normally again. 🎉

from agregore-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.