Giter Site home page Giter Site logo

Comments (6)

RangerMauve avatar RangerMauve commented on May 21, 2024 2

Hey, I've submitted a pull request to Electron to fix this. Hopefully we'll be able to get it merged sooner than later and then get it merged into agregore. Sadly it looks like we'll be stuck using the default port in the meantime.

electron/electron#26803

from agregore-browser.

RangerMauve avatar RangerMauve commented on May 21, 2024

Interesting! Thank you for reporting this bug. I'm not sure what's causing it.

Would you feel comfortable debugging this a little? If you clone agregore and try to run it from the command line, you should be seeing the requests coming in due to this console log statenebts

Is the correct port present there when the request happens?

from agregore-browser.

RangerMauve avatar RangerMauve commented on May 21, 2024

Also thank you for your patience! I hadn't gone through my notifications in a few days. 😅

from agregore-browser.

Alch-Emi avatar Alch-Emi commented on May 21, 2024

Thanks for the response! Unfortunately I just reworked my site not to use an alternate port, but the bug still seems to be present. Here's the relevant snippet of the log:

<- 3 searchHistory ( [ 'gemini://alchemi.dev:1995', 1606889303532 ] )
<- 3 setBounds ( [ { x: 0, y: 36, width: 1366, height: 732 } ] )
<- 3 setBounds ( [ { x: 0, y: 75, width: 1366, height: 693 } ] )
<- 3 getURL ( [] )
<- 3 loadURL ( [ 'gemini://alchemi.dev:1995' ] )
<- 3 focus ( [] )
<- 3 setBounds ( [ { x: 0, y: 36, width: 1366, height: 732 } ] )
Navigating gemini://alchemi.dev/
-> 3 navigating ( [ 'gemini://alchemi.dev/' ] )
-> 3 history-buttons-change ( [ { canGoBack: true, canGoForward: false } ] )
{
  method: 'GET',
  url: 'gemini://alchemi.dev/',
  referrer: '',
  headers: {
    Accept: 'text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9'
  }
}

from agregore-browser.

RangerMauve avatar RangerMauve commented on May 21, 2024

Well shoot. It's a bug in Electron.

It's swallowing the port section for custom protocols. :(

You can verify this by pasting new URL('gemini://alchemi.dev:1995/') in your JS console if you hit ctrl+shift+i

We'll need to open an issue on the Electron repo and see if they know what to do about it.

from agregore-browser.

RangerMauve avatar RangerMauve commented on May 21, 2024

Related to this: electron/electron#24725

from agregore-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.