ECONNREFUSED

[agsh]

ECONNREFUSED

[agsh]

I strongly agree with you, this wasn't my patch, missed this out. Replaced console.error with callbacks but saved if cases for debugging purposes ce1e4eb

[kruschid]

Same problem here. Instead of printing the error to console in some cases, the script should call the callback function for every case, right? Might be useful for debugging but it isn't in production mode. :-(

Cam.js: lines 185 - 193

/* address, port number or IPCam error */
if (err.code === 'ECONNREFUSED' && err.errno === 'ECONNREFUSED'  && err.syscall === 'connect') {
    console.error(err);  
/* network error */
} else if (err.code === 'ECONNRESET' && err.errno === 'ECONNRESET'  && err.syscall === 'read') {
    console.error(err);
} else {
    callback(err);
}

[kruschid]

thank you ;-)

[bluet]

ah, sorry for that.
I asked @sunnyworm to send PR if he fixed the connection refuse bug with a broken firmware on one of our IPcam, but I forgot to do code review...
https://github.com/agsh/onvif/blame/fbf1cf9a7e165a440d9193f6804669d815f822f4/lib/cam.js#L186

Will mention this to him and prevent any further bug like this.
Thanks @agsh for fixing!

[scriby]

Ran into this today as well, thanks for fixing.

Can we get this released on npm?

[agsh]

Done! 0.4.3