Plain text component values

[ahkab]

Plain text component values

[itdaniher]

Hey there! Somehow this originally fell threw the cracks in my inbox, but the improvement looks great and I'd love to figure out how to get it merged!

[itdaniher]

Thinking about this further:

I like

value = value_parser_and_checker(value, should_be='ohm')
if value is None:
    raise CircuitTypeError("Circuit components need to have nonzero values)

This way, I think we have a utility function to add, which you already wrote, and hooks to add to the __init__ methods of the relevant classes, or, less generally, in the Circuit.add_foo methods for each circuit element.

Personally, I'd move even the existing if value == 0 check into the __init__ calls for each circuit element, as they're only implemented for a few select components, and it might be worth adding sanity checks that keep someone from trying to simulate the transient response of a circuit with a 1 megafarad capacitor and a 1 megaohm resistor, or other equally awkward unit-ed component combinations.

[itdaniher]

We already have more infrastructure for this than I realised, as G took the initiative to work towards SPICE syntax compatibility!

http://ahkab.readthedocs.io/en/latest/netlist_parser.html?highlight=convert_units#ahkab.netlist_parser.convert_units

Found just reading netlist_parser thinking about unicode units.....

[endolith]

SPICE annoyingly equates M with "milli", when it means "mega" everywhere else. Also what is mil = 25.4x1e-6 for? PCB dimensions?

Anyway the intent was for this to be for the pythonic API, not SPICE.