Comments (4)
@fabioconti thanks for your input. can you please check the files in the zip and confirm that the halkaBox is being exported? thanks.
node index.js
from halkabox.js.
@ahmednooor it prints stuff, but doesn't seem to init galleries :(
from halkabox.js.
the problem seems to be here:
// collecting all the anchor tags having data-hb attribute with their respective values
imageLinks = document.getElementsByClassName(selector),
I used data-hb selector and not class, but data-hb attribute is ignored in the code :)
I'm goin to correct this in my html output, but I suppose it's better to use the data-hb attribute, at least I think it's a cleaner solution.
Anyway I think you can uglify the file you sent me and put it in dist.
from halkabox.js.
@fabioconti thanks for your input. actually i changed data-hb
to class
for backwards compatibility and ease of use. most new comers to html usually only know about a handful of attributes such as id and class (personal experience). besides class is almost used on every element so why introduce more weight to the html while we can get the work done without it.
i have added the feature in the new release (link below). closing this issue now. feel free to report any future bugs/issues.
module.exports
added.
1.2.0
from halkabox.js.
Related Issues (19)
- Browser scrollbar HOT 2
- Screen width switch bug HOT 4
- Option for Image List HOT 4
- Some callback for onChange HOT 1
- autoplay HOT 3
- List of galleries HOT 2
- Append description of image HOT 6
- Crossdomain
- box-shadow HOT 2
- [Feature Request] Add option to destroy instance HOT 5
- light-grey control buttons when resizing window, using dark theme HOT 6
- Gesture to close on touch devices HOT 5
- wheelhandler is too sensitive on desktop HOT 4
- Use html5 data-title instead of native title attribute HOT 3
- Double click/tap to zoom in/out HOT 5
- cursor-issue zoom HOT 1
- Transparent PNG HOT 2
- Create gallery items via JSON array HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from halkabox.js.