Giter Site home page Giter Site logo

Comments (8)

SumanohariR avatar SumanohariR commented on June 11, 2024

Hello, I hope you're all doing well!
Could you please confirm whether this issue has already been assigned to someone? If it hasn't it would be a pleasure to contribute to your project!

from commands.

chickeneer avatar chickeneer commented on June 11, 2024

I would confirm that no one is working on this "issue". Truthfully, I have not put any thought into what this looks like to implement. Or anything else about it.

from commands.

SumanohariR avatar SumanohariR commented on June 11, 2024

It would be helpful if you could provide a description of the issue! @vortexthedev @chickeneer

from commands.

vortexthedev avatar vortexthedev commented on June 11, 2024

It would be helpful if you could provide a description of the issue! @vortexthedev @chickeneer

The title of issue is saying everything

from commands.

vortexthedev avatar vortexthedev commented on June 11, 2024

Add @async annotation, so we can get rid of non-async database queries for example in the registered contexts (params).

from commands.

vortexthedev avatar vortexthedev commented on June 11, 2024

I would confirm that no one is working on this "issue". Truthfully, I have not put any thought into what this looks like to implement. Or anything else about it.

Could you implement next methods? (If any of registered contexts are async, then the whole command execution will be off main thread by using runTaskAsync?)

CommandManager#registerAsyncContext
CommandManager#registerAsyncOptionalContext
CommandManager#registerAsyncIssuerAwareContext

Add @async annotation so we can select any commands besides the params to be async.

from commands.

Joo200 avatar Joo200 commented on June 11, 2024

No, there are some open things:

  • How should acf handle async resolvers. Should they be registered and instead of returning the object directly a CompletionStage? Or should the context resolver simply be called async?
  • Should the execution of the command be async (off main thread) or rescheduled into the main thread?
  • Since it's possible to access values from other arguments with the provided context in the context resolver there should be more information on how to implement this feature for async contexts.

Feel free to make a PoC by forking acf yourself and try to implement such a feature. If anyone could implement that in a few minutes we would already added it as a feature to acf. But such a complex idea should be implemented correctly and the required time for this is huge.

from commands.

vortexthedev avatar vortexthedev commented on June 11, 2024

If there is any parameters that are required to be run async, or the command/subcommand has @async annotation, then the whole command process (Command#execute) will be ran through Scheduler#runTaskAsync().
By the command process I mean retrieving the parameters values through registered contexts and running the command method.

from commands.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.