Exception during upload_stream causes hang

[heftig]

Exception during upload_stream causes hang

[heftig]

Interestingly, if you pass instead of raise, it works fine.

I wonder what's going on. The code paths seem to be the same since neither __aexit__ is actually interested in the exception.

[pohmelie]

@heftig, probably something differs at flushing quit, so on raise there is no real data transfer.

add the write_eof to DataConnectionThrottleStreamIO.__aexit__

This definitely should be there, thanks! 👍

[heftig]

The code paths seem to be the same since neither aexit is actually interested in the exception.

Strike that; DataConnectionThrottleStreamIO.__aexit__ doesn't call finish if there's an exception. As a result, close doesn't get called either, and the connection stays open.

So write_eof was a red herring, and it was really the missing close.

I guess since every write on the stream does a drain, write_eof isn't needed?

[heftig]

AFAIK normally to close a connection you write_eof, then await drain and then close, to ensure all bytes have been sent.

[pohmelie]

It looks like writer.close() is enough here. Since write_eof closing only writing, but you can still read (as documentation said). Also, not all transports support write_eof.
Is it enough?

async def __aexit__(self, exc_type, exc, tb):

    if exc is None:

        await self.finish()

    else:

        self.close()

[heftig]

Yes, that works too, thanks.