Access point setup fails if enabling ac mode

[evilphish]

Access point setup fails if enabling ac mode

[evilphish]

Some further information and I am not sure whether this is a problem of this driver or hostapd but I am leaning towards the former:

It seems the setup of the hostap fails because it thinks that the wireless adapter does not provide certain capabilities even though it does. An example:

iw list reports
VHT RX MCS set:
1 streams: MCS 0-9
2 streams: MCS 0-9

This tells us that we have 2 supported streams which means we can use
[RX-STBC-12]
as a configuration flag for the vht capabilities config in hostapd. The problem is that while iw list can obviously report the correct capabilities of the card, when hostapd asks the 8812 driver for its capabilities the driver reports that the card does not have this capability. If I take the source of hostapd and remove the check whether a card actually has the configured capabilities the access point starts up fine in ac mode. However, this is quite a dirty hack and apparently with other drivers hostapd has no difficulties when asking for the capabilities of a card. The same problem also occurs with ht capabilities, nost just vht.

[kimocoder]

Thanks! again, great information! I've seen a commit in another repo with some fixes for VHT, compared it to this code and lots seemed missing here. The weekend is set to investigate further, I'll post the commit from the repo I've when I'm back at my computer then you'll see the issue I REF too.

The HT caps I didn't know about though.

These drivers is a mix of old/new code and gots some issues that has to be resolved.
I'll get back to you this weekend with some VHT info. That's a starter.

[kimocoder]

here are some interesting readings about the issue.

A commit made here too

[evilphish]

Sure go ahead. Also when checking my card with iw list, the vht capabilities are reported as
VHT Capabilities (0x000010b0):
Max MPDU length: 3895
Supported Channel Width: neither 160 nor 80+80
RX LDPC
short GI (80 MHz)
TX STBC
SU Beamformee

technically there is nothing here that points to RX STBC 12, it just mentions TX STBC. Of course in my last post I showed an excerpt of the following info block in iw list which goes:
VHT RX MCS set:
1 streams: MCS 0-9
2 streams: MCS 0-9
3 streams: not supported
4 streams: not supported
5 streams: not supported
6 streams: not supported
7 streams: not supported
8 streams: not supported
VHT RX highest supported: 866 Mbps

and this clearly shows that there are 2 streams available. I don't know whether hostapd maybe expects the information regarding the streams as a flag in the VHT capabilities block. This also seems to be somewhat of a general issue as you can find loads of example or tutorial posts which show iw list outputs with more than 1 stream and the corresponding example hostapd config only using RX-STBC-1 which is supposed to disallow usage of more than one stream.

I am at a total loss whether the RX-STBC-12 is supposed to be included in the VHT capabilities block but I guess it would make sense to have all capabilities as flags in one place and not spread the information accross different blocks of information.

Either way if you need further stuff or want to do some testing on the weekend I am game.

Oh and regarding your interesting link, it seems like they introduced functions to basically prime the card in order to activate the capabilities? I think I read somewhere that some cards do not advertise certain capabilities unless you activate them which is pretty problematic if a piece of software only enables capabilities that are advertised :) It's like a wireless mexican standoff ^^

[kimocoder]

Actually, look at this one. Try changing these, it's in the Makefile.
It's disabled by default, just checked.. but I ain't near any computer at the moment.

[evilphish]

compiles with a warning
WARNING: "mpt_ProSetPMacTx" [rtl8812au-kimo-4.3.21/8812au.ko] undefined!

which leads to an error when trying to modprobe 8812au
modprobe: ERROR: could not insert '8812au': Unknown symbol in module, or unknown parameter (see dmesg)

and dmesg complains:
8812au: Unknown symbol mpt_ProSetPMacTx (err 0)

[kimocoder]

Ok. it works on the v5.1.5 branch a user confirms, but he got no knowledge on testing.
v4.3.21 branch hmmm.. unsure on the future support for it, as the main work is now focused on v5.1.5.

I'll uploads the info he sends me in short time

Simply can't wait to get back home.

[kimocoder]

This is the 8814au after enabling "CONFIG_MP_VHT_HW_TX_MODE" in Makefile @ v5.1.5 branch
iw_phy_new.txt

Wiphy phy8
max # scan SSIDs: 9
max scan IEs length: 2304 bytes
max # sched scan SSIDs: 0
max # match sets: 0
max # scan plans: 1
max scan plan interval: -1
max scan plan iterations: 0
Retry short limit: 7
Retry long limit: 4
Coverage class: 0 (up to 0m)
Supported Ciphers:
* WEP40 (00-0f-ac:1)
* WEP104 (00-0f-ac:5)
* TKIP (00-0f-ac:2)
* CCMP-128 (00-0f-ac:4)
Available Antennas: TX 0 RX 0
Supported interface modes:
* IBSS
* managed
* AP
* monitor
* P2P-client
* P2P-GO
Band 1:
Capabilities: 0x1963
RX LDPC
HT20/HT40
Static SM Power Save
RX HT20 SGI
RX HT40 SGI
RX STBC 1-stream
Max AMSDU length: 7935 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 16 usec (0x07)
HT Max RX data rate: 450 Mbps
HT TX/RX MCS rate indexes supported: 0-23
Bitrates (non-HT):
* 1.0 Mbps
* 2.0 Mbps
* 5.5 Mbps
* 11.0 Mbps
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 2412 MHz [1] (20.0 dBm)
* 2417 MHz [2] (20.0 dBm)
* 2422 MHz [3] (20.0 dBm)
* 2427 MHz [4] (20.0 dBm)
* 2432 MHz [5] (20.0 dBm)
* 2437 MHz [6] (20.0 dBm)
* 2442 MHz [7] (20.0 dBm)
* 2447 MHz [8] (20.0 dBm)
* 2452 MHz [9] (20.0 dBm)
* 2457 MHz [10] (20.0 dBm)
* 2462 MHz [11] (20.0 dBm)
* 2467 MHz [12] (20.0 dBm)
* 2472 MHz [13] (20.0 dBm)
* 2484 MHz [14] (20.0 dBm)
Band 2:
Capabilities: 0x1863
RX LDPC
HT20/HT40
Static SM Power Save
RX HT20 SGI
RX HT40 SGI
No RX STBC
Max AMSDU length: 7935 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 16 usec (0x07)
HT Max RX data rate: 450 Mbps
HT TX/RX MCS rate indexes supported: 0-23
VHT Capabilities (0x000010b0):
Max MPDU length: 3895
Supported Channel Width: neither 160 nor 80+80
RX LDPC
short GI (80 MHz)
TX STBC
SU Beamformee
VHT RX MCS set:
1 streams: MCS 0-9
2 streams: MCS 0-9
3 streams: MCS 0-9
4 streams: MCS 0-9
5 streams: not supported
6 streams: not supported
7 streams: not supported
8 streams: not supported
VHT RX highest supported: 1733 Mbps
VHT TX MCS set:
1 streams: MCS 0-9
2 streams: MCS 0-9
3 streams: MCS 0-9
4 streams: MCS 0-9
5 streams: not supported
6 streams: not supported
7 streams: not supported
8 streams: not supported
VHT TX highest supported: 1733 Mbps
Bitrates (non-HT):
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 5170 MHz [34] (30.0 dBm)
* 5180 MHz [36] (30.0 dBm)
* 5190 MHz [38] (30.0 dBm)
* 5200 MHz [40] (30.0 dBm)
* 5210 MHz [42] (30.0 dBm)
* 5220 MHz [44] (30.0 dBm)
* 5230 MHz [46] (30.0 dBm)
* 5240 MHz [48] (30.0 dBm)
* 5260 MHz [52] (30.0 dBm) (no IR, radar detection)
* 5280 MHz [56] (30.0 dBm) (no IR, radar detection)
* 5290 MHz [58] (30.0 dBm) (no IR, radar detection)
* 5300 MHz [60] (30.0 dBm) (no IR, radar detection)
* 5310 MHz [62] (30.0 dBm) (no IR, radar detection)
* 5320 MHz [64] (30.0 dBm) (no IR, radar detection)
* 5500 MHz [100] (30.0 dBm) (no IR, radar detection)
* 5520 MHz [104] (30.0 dBm) (no IR, radar detection)
* 5540 MHz [108] (30.0 dBm) (no IR, radar detection)
* 5560 MHz [112] (30.0 dBm) (no IR, radar detection)
* 5580 MHz [116] (30.0 dBm) (no IR, radar detection)
* 5600 MHz [120] (30.0 dBm) (no IR, radar detection)
* 5620 MHz [124] (30.0 dBm) (no IR, radar detection)
* 5640 MHz [128] (30.0 dBm) (no IR, radar detection)
* 5660 MHz [132] (30.0 dBm) (no IR, radar detection)
* 5680 MHz [136] (30.0 dBm) (no IR, radar detection)
* 5700 MHz [140] (30.0 dBm) (no IR, radar detection)
* 5720 MHz [144] (30.0 dBm) (radar detection)
* 5745 MHz [149] (30.0 dBm) (radar detection)
* 5765 MHz [153] (30.0 dBm) (radar detection)
* 5785 MHz [157] (30.0 dBm) (radar detection)
* 5805 MHz [161] (30.0 dBm)
* 5825 MHz [165] (30.0 dBm) (radar detection)
* 5845 MHz [169] (30.0 dBm)
* 5920 MHz [184] (30.0 dBm)
* 5940 MHz [188] (30.0 dBm)
* 5960 MHz [192] (30.0 dBm)
* 5980 MHz [196] (30.0 dBm)
* 6000 MHz [200] (30.0 dBm)
* 6020 MHz [204] (30.0 dBm)
* 6040 MHz [208] (30.0 dBm)
* 6060 MHz [212] (30.0 dBm)
* 6080 MHz [216] (30.0 dBm)
Supported commands:
* new_interface
* set_interface
* new_key
* start_ap
* new_station
* set_bss
* join_ibss
* set_pmksa
* del_pmksa
* flush_pmksa
* remain_on_channel
* frame
* set_channel
* connect
* disconnect
Supported TX frame types:
* IBSS: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* AP/VLAN: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
Supported RX frame types:
* IBSS: 0xd0
* managed: 0x40 0xd0
* AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* AP/VLAN: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* P2P-client: 0x40 0xd0
* P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
WoWLAN support:
* wake up on anything (device continues operating normally)
software interface modes (can always be added):
* monitor
interface combinations are not supported
Device supports scan flush.
Wiphy phy0
max # scan SSIDs: 20
max scan IEs length: 195 bytes
max # sched scan SSIDs: 0
max # match sets: 0
max # scan plans: 1
max scan plan interval: -1
max scan plan iterations: 0
Retry short limit: 7
Retry long limit: 4
Coverage class: 0 (up to 0m)
Device supports RSN-IBSS.
Supported Ciphers:
* WEP40 (00-0f-ac:1)
* WEP104 (00-0f-ac:5)
* TKIP (00-0f-ac:2)
* CCMP-128 (00-0f-ac:4)
* CCMP-256 (00-0f-ac:10)
* GCMP-128 (00-0f-ac:8)
* GCMP-256 (00-0f-ac:9)
Available Antennas: TX 0 RX 0
Supported interface modes:
* IBSS
* managed
* AP
* AP/VLAN
* monitor
Band 1:
Capabilities: 0x107e
HT20/HT40
SM Power Save disabled
RX Greenfield
RX HT20 SGI
RX HT40 SGI
No RX STBC
Max AMSDU length: 3839 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 4 usec (0x05)
HT Max RX data rate: 300 Mbps
HT TX/RX MCS rate indexes supported: 0-15
Bitrates (non-HT):
* 1.0 Mbps
* 2.0 Mbps (short preamble supported)
* 5.5 Mbps (short preamble supported)
* 11.0 Mbps (short preamble supported)
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 2412 MHz [1] (15.0 dBm)
* 2417 MHz [2] (15.0 dBm)
* 2422 MHz [3] (15.0 dBm)
* 2427 MHz [4] (15.0 dBm)
* 2432 MHz [5] (15.0 dBm)
* 2437 MHz [6] (15.0 dBm)
* 2442 MHz [7] (15.0 dBm)
* 2447 MHz [8] (15.0 dBm)
* 2452 MHz [9] (15.0 dBm)
* 2457 MHz [10] (15.0 dBm)
* 2462 MHz [11] (15.0 dBm)
* 2467 MHz [12] (15.0 dBm) (no IR)
* 2472 MHz [13] (15.0 dBm) (no IR)
Band 2:
Capabilities: 0x107e
HT20/HT40
SM Power Save disabled
RX Greenfield
RX HT20 SGI
RX HT40 SGI
No RX STBC
Max AMSDU length: 3839 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 4 usec (0x05)
HT Max RX data rate: 300 Mbps
HT TX/RX MCS rate indexes supported: 0-15
Bitrates (non-HT):
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 5180 MHz [36] (15.0 dBm) (no IR)
* 5200 MHz [40] (15.0 dBm) (no IR)
* 5220 MHz [44] (15.0 dBm) (no IR)
* 5240 MHz [48] (15.0 dBm) (no IR)
* 5260 MHz [52] (15.0 dBm) (no IR, radar detection)
* 5280 MHz [56] (15.0 dBm) (no IR, radar detection)
* 5300 MHz [60] (15.0 dBm) (no IR, radar detection)
* 5320 MHz [64] (15.0 dBm) (no IR, radar detection)
* 5500 MHz [100] (15.0 dBm) (no IR, radar detection)
* 5520 MHz [104] (15.0 dBm) (no IR, radar detection)
* 5540 MHz [108] (15.0 dBm) (no IR, radar detection)
* 5560 MHz [112] (15.0 dBm) (no IR, radar detection)
* 5580 MHz [116] (15.0 dBm) (no IR, radar detection)
* 5600 MHz [120] (15.0 dBm) (no IR, radar detection)
* 5620 MHz [124] (15.0 dBm) (no IR, radar detection)
* 5640 MHz [128] (15.0 dBm) (no IR, radar detection)
* 5660 MHz [132] (15.0 dBm) (no IR, radar detection)
* 5680 MHz [136] (15.0 dBm) (no IR, radar detection)
* 5700 MHz [140] (15.0 dBm) (no IR, radar detection)
* 5745 MHz [149] (15.0 dBm) (no IR, radar detection)
* 5765 MHz [153] (15.0 dBm) (no IR, radar detection)
* 5785 MHz [157] (15.0 dBm) (no IR, radar detection)
* 5805 MHz [161] (disabled)
* 5825 MHz [165] (15.0 dBm) (no IR, radar detection)
Supported commands:
* new_interface
* set_interface
* new_key
* start_ap
* new_station
* new_mpath
* set_mesh_config
* set_bss
* authenticate
* associate
* deauthenticate
* disassociate
* join_ibss
* join_mesh
* set_tx_bitrate_mask
* frame
* frame_wait_cancel
* set_wiphy_netns
* set_channel
* set_wds_peer
* probe_client
* set_noack_map
* register_beacons
* start_p2p_device
* set_mcast_rate
* connect
* disconnect
* set_qos_map
* Unknown command (121)
Supported TX frame types:
* IBSS: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* AP/VLAN: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* mesh point: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
Supported RX frame types:
* IBSS: 0x40 0xb0 0xc0 0xd0
* managed: 0x40 0xd0
* AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* AP/VLAN: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* mesh point: 0xb0 0xc0 0xd0
* P2P-client: 0x40 0xd0
* P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* P2P-device: 0x40 0xd0
WoWLAN support:
* wake up on disconnect
* wake up on magic packet
* wake up on pattern match, up to 20 patterns of 16-128 bytes,
maximum packet offset 0 bytes
* can do GTK rekeying
* wake up on GTK rekey failure
* wake up on EAP identity request
* wake up on rfkill release
software interface modes (can always be added):
* AP/VLAN
* monitor
valid interface combinations:
* #{ managed } <= 1, #{ AP } <= 1,
total <= 2, #channels <= 1, STA/AP BI must match
* #{ managed } <= 2,
total <= 2, #channels <= 1
HT Capability overrides:
* MCS: ff ff ff ff ff ff ff ff ff ff
* maximum A-MSDU length
* supported channel width
* short GI for 40 MHz
* max A-MPDU length exponent
* min MPDU start spacing
Device supports TX status socket option.
Device supports HT-IBSS.
Device supports SAE with AUTHENTICATE command
Device supports scan flush.
Device supports per-vif TX power setting
Driver supports full state transitions for AP/GO clients
Driver supports a userspace MPM
Device supports static SMPS
Device supports dynamic SMPS
Device supports configuring vdev MAC-addr on create.

[evilphish]

Interesting, vht caps say nothing about the rx-stbc besides listing 4 streams in the next block. Which would mean one should be able to use RX-STBC-1234 as a flag in hostapd and I would bet that it will complain about missing capabilities in that case...

I will have to hit the sack for today anyway :) Maybe, in combination with the other issue I opened, if we can get the usb3 stuff fixed in 5.1.5 I would be more than happy to switch sources and continue the hunt on 5.1.5 if you are interested. I also do not see a big gain from pouring too much work into 4.3.21 but alas, it is the most feature complete as of now I guess.

[kimocoder]

Great sir!

We'll get back to it. Got some intel on the USB3 stuff (EEPROM USBModeSwitch) too.
Have a good one in the meantime & thanks.

[evilphish]

Now that the USB3 part apparently is solved, I have bad news for this issue. Even with 5.1.5 or 5.2.9 the module is not loadable:
8812au: Unknown symbol mpt_ProSetPMacTx (err 0)

This might be related to you using the 8814 driver and not the 8812.
I am currently trying to find out where this gets defined but grep is of no big help. I will keep looking but maybe you have more luck :)

[dfiloni]

I am currently trying to find out where this gets defined but grep is of no big help. I will keep looking but maybe you have more luck :)

You can find it here: https://github.com/aircrack-ng/rtl8812au/blob/v5.1.5/hal/hal_mp.c#L2185

[kimocoder]

Remember, I also did this, but if it was SMART or not, maybe you could decide that part. Should it be left commented out, or simply changed back?

[dfiloni]

In order to build CONFIG_MP_VHT_HW_TX_MODE for 8812 I think you have to change:

hal/hal_mp.c:#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8821B) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C)
os_dep/linux/ioctl_mp.c:#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8821B) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C)

to:
#ifdef CONFIG_MP_VHT_HW_TX_MODE

I don't have a 8812 to test this.

@kimocoder : about your question, I think you should try to fix hal_ReadUsbModeSwitch_8814AU [1], hal_ReadUsbModeSwitch_8812AU [2] is properly implemented, you'll have to use EEPROM_USB_MODE_8814A instead of EEPROM_USB_MODE_8812, I think this could work.
[1] https://github.com/aircrack-ng/rtl8812au/blob/v5.1.5/hal/rtl8814a/usb/usb_halinit.c#L2007
[2] https://github.com/aircrack-ng/rtl8812au/blob/v5.1.5/hal/rtl8812a/usb/usb_halinit.c#L2249

[evilphish]

Thanks for the hint @dfiloni.
This is not the only thing that needs changing but there are a couple more. I managed to get all and let it compile. It ended up being a bit messy though since I had to edit a couple of ifdefs in order to include 8814A stuff for using it for the 8812 module. Don't know whether this should be capsulated or just commented and left as is.

either way, hostapd still complains...

Driver does not support configured HT capability [TX-STBC]

I shall look further, this is what I have so far:

diff --git a/Makefile b/Makefile
index b689e06..67d99cf 100755
--- a/Makefile
+++ b/Makefile
@@ -85,7 +85,7 @@ CONFIG_AP_WOWLAN = n
 ######### Notify SDIO Host Keep Power During Syspend ##########
 CONFIG_RTW_SDIO_PM_KEEP_POWER = y
 ###################### MP HW TX MODE FOR VHT #######################
-CONFIG_MP_VHT_HW_TX_MODE = n
+CONFIG_MP_VHT_HW_TX_MODE = y
 ###################### Platform Related #######################
 CONFIG_PLATFORM_I386_PC = y
 CONFIG_PLATFORM_ANDROID_X86 = n
diff --git a/hal/hal_mp.c b/hal/hal_mp.c
index bf6b4c2..37bd4b1 100644
--- a/hal/hal_mp.c
+++ b/hal/hal_mp.c
@@ -35,7 +35,7 @@
        #ifdef CONFIG_RTL8192E
                #include <rtl8192e_hal.h>
        #endif
-       #ifdef CONFIG_RTL8814A
+       #if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8812A)
                #include <rtl8814a_hal.h>
        #endif
        #if defined(CONFIG_RTL8812A) || defined(CONFIG_RTL8821A)
@@ -841,7 +841,7 @@ VOID mpt_SetRFPath_8814A(PADAPTER   pAdapter)
        mpt_ToggleIG_8814A(pAdapter);
 }
 #endif /* CONFIG_RTL8814A */
-#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C)
+#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C) || defined(CONFIG_RTL8812A)
 VOID
 mpt_SetSingleTone_8814A(
        IN      PADAPTER        pAdapter,
@@ -2038,7 +2038,7 @@ u32 hal_mpt_query_phytxok(PADAPTER        pAdapter)
 
 }
 
-#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8821B) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C)
+#if defined(CONFIG_MP_VHT_HW_TX_MODE)
 /* for HW TX mode */
 static VOID mpt_StopCckContTx(
        PADAPTER        pAdapter
diff --git a/os_dep/linux/ioctl_mp.c b/os_dep/linux/ioctl_mp.c
index e2d34f5..ef1dee8 100644
--- a/os_dep/linux/ioctl_mp.c
+++ b/os_dep/linux/ioctl_mp.c
@@ -1947,7 +1947,7 @@ int rtw_mp_hwtx(struct net_device *dev,
        struct mp_priv *pmp_priv = &padapter->mppriv;
        PMPT_CONTEXT            pMptCtx = &(padapter->mppriv.MptCtx);
 
-#if defined(CONFIG_RTL8814A) || defined(CONFIG_RTL8821B) || defined(CONFIG_RTL8822B) || defined(CONFIG_RTL8821C)
+#if defined(CONFIG_MP_VHT_HW_TX_MODE)
        u8              input[wrqu->data.length];
 
        if (copy_from_user(input, wrqu->data.pointer, wrqu->data.length))

[evilphish]

@kimocoder regarding your change with the eeprom, I have uncommented it and it still works at my end.

[dfiloni]

@evilphish : please try enabling: CONFIG_80211N_HT

[evilphish]

added an
EXTRA_CFLAGS += -DCONFIG_80211N_HT
but it doesn't change anything. Still no STBC

[evilphish]

closed due to it being solved. txpower issue remains in its own thread #29