Giter Site home page Giter Site logo

Comments (9)

bchah avatar bchah commented on August 17, 2024

@SangwonOh any idea what could be the cause?

from ovenplayer.

bchah avatar bchah commented on August 17, 2024

@SangwonOh Is there any help available for this? My iPhone users cant go fullscreen anymore. It's likely affecting your OvenStudio LLHLS product too so it's worth looking into.

from ovenplayer.

SangwonOh avatar SangwonOh commented on August 17, 2024

@bchah I'll find out as soon as possible

from ovenplayer.

SangwonOh avatar SangwonOh commented on August 17, 2024

@bchah Full screen seems to work well in iOS 17.1.1.
There are no errors in my inspector. ðŸĪ”
Which iOS version are you using?

from ovenplayer.

getroot avatar getroot commented on August 17, 2024

My iPhone is 17.2 beta3, and full screen works fine on my phone as well.

from ovenplayer.

bchah avatar bchah commented on August 17, 2024

I have no idea why, but I can easily reproduce this on multiple iPhones running the latest iOS release 17.1.1. It's not an issue on iOS 16, or iPadOS.

Here is an iPhone 15 and iPhone 12 both on the same iOS (the web inspector at the end is from the 15):

IMG_0028.mp4

Even stranger is, I found a workaround for now. If you hit the error then reload the page, the player will go fullscreen when you hit play:

IMG_0029.mp4

from ovenplayer.

SangwonOh avatar SangwonOh commented on August 17, 2024

@bchah Hi 😀 It's very strange. I made some code change. Could you test this alpha version?

https://cdn.jsdelivr.net/npm/[email protected]/dist/ovenplayer.min.js

from ovenplayer.

bchah avatar bchah commented on August 17, 2024

Thank you @SangwonOh - the good news is, 0.10.33 does not cause an error in the Web Inspector ðŸ˜ļ The bad news is, the problem is still happening where the player does not go fullscreen ðŸ˜ŋ I will look closer in a debugger and see what has changed about the code flow in Safari 17 (iOS 17). It could be something with the webkitEnterFullScreen API. 🍎ðŸĪŠ

from ovenplayer.

bchah avatar bchah commented on August 17, 2024

@SangwonOh This issue seems to be resolved by iOS 17.2 😅

from ovenplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google âĪïļ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.