Giter Site home page Giter Site logo

Comments (7)

thuanaislab avatar thuanaislab commented on August 20, 2024 1

Thank you for your interest in our work.
The issue you got shows that you probably forgot to keep the threshold with Superpoint when running Hloc.
Note that only when you have the same number of descriptors per image, you can train the framework with batch size > 1 (in the code the batch size is 8)
Another simple solution is: change the batch size to 1 when training. It will work but I'm not sure it gonna show the best results.

You can change the config of superpoint as follows to get the same number of descriptors:

class SuperPoint(nn.Module):
    default_config = {
        'descriptor_dim': 256,
        'nms_radius': 4,
        'refinement_radius': 0,
        'do_quadratic_refinement': 0,
        'keypoint_threshold': 0.005, # please change to 0.0
        'max_keypoints': -1, # please change to number keypoints you need, ex: 2048
        'remove_borders': 4,
    }

from feat2map.

SunJ1025 avatar SunJ1025 commented on August 20, 2024

I found the descriptors are not the same size, do you konw which step is wrong, leading to a different descriptor sizes?

from feat2map.

SunJ1025 avatar SunJ1025 commented on August 20, 2024

Thank you for your quick response!I'll have a try.

from feat2map.

SunJ1025 avatar SunJ1025 commented on August 20, 2024

Sorry to bother you again, but I still have the same problem after modifying max_keypoints=2048, it seems that it's because too few descriptors are fetched, for example [256,835] [256,829], so max_keypoints can't be limited uniformly, do you have any idea about the reason for this?

from feat2map.

thuanaislab avatar thuanaislab commented on August 20, 2024

I think you forgot to change the threshold of 'keypoint_threshold': 0.005 to 'keypoint_threshold': 0.0. Additionally, please change the config in Hloc at the parents configuration, the example I have shown above is just for a fast response but would not correctly set the Superpoint parameters for entire Hloc framework. This is why you still received the number of descriptors per image around 835 keypoints.

from feat2map.

SunJ1025 avatar SunJ1025 commented on August 20, 2024

Hello, I have tried to set 'keypoint_threshold': 0.0 in the configs of Hloc, I think the set of configs are right.
Maybe it's that 2048 keypoints cannot be extracted from a single image, even if the threshold is set to 0.
I‘m not sure if I understand correctly ?

from feat2map.

thuanaislab avatar thuanaislab commented on August 20, 2024

As long as your image size is not too small, you can manage to get specific number of keypoints as you want.

from feat2map.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.