skel.lock Cookie

[ajlkn]

skel.lock Cookie

[ajlkn]

That looks about right actually. I'll do some testing with this and push out a fix (along with something to address the path thing you pointed out). Good catch.

[jmalatia]

Thanks for the response. Great framework!

If you do decide to allow flexibility for setting the cookie "path", you
may also consider allowing for flexibility to set the cookie "expires"
property as well to allow for it to be a session only cookie. I think
incorporating both is a plus and would be utilized by those designing
for skeljs.

For Example:
path:  page or site,  ("" or "/")
expires:  session  or  maybe # of days from today  (0=session or
n=#Days)

Thanks Again.

-------- Original Message --------
Subject: Re: [skelJS] skel.lock Cookie (#15)
Date: 10/23/2013 1:47 PM

That looks about right actually. I'll do some testing with this and
push out a fix (along with something to address the path thing you
pointed out). Good catch.

—
Reply to this email directly or view it on GitHub
#15 (comment).

[ajlkn]

Yeah, though to keep things simple both "path" and "expiration" will
probably end up being toggles (path = page or site, expiration = session
or perpetual).

On 10/23/2013 2:33 PM, jmalatia wrote:

Thanks for the response. Great framework!

If you do decide to allow flexibility for setting the cookie "path", you
may also consider allowing for flexibility to set the cookie "expires"
property as well to allow for it to be a session only cookie. I think
incorporating both is a plus and would be utilized by those designing
for skeljs.

 For Example:
 path:  page or site,  ("" or "/")
 expires:  session  or  maybe # of days from today  (0=session or
 n=#Days)

Thanks Again.

-------- Original Message --------
Subject: Re: [skelJS] skel.lock Cookie (#15)
From: aj [email protected]
To: n33/skelJS [email protected]
Cc: jmalatia [email protected]
Date: 10/23/2013 1:47 PM

That looks about right actually. I'll do some testing with this and
push out a fix (along with something to address the path thing you
pointed out). Good catch.

—
Reply to this email directly or view it on GitHub
#15 (comment).

---

Reply to this email directly or view it on GitHub:
#15 (comment)

[ajlkn]

Implemented in 0.4.3 (see usePerpetualLock and useDomainLock options).

[jmalatia]

Thanks! I appreciate it!

-------- Original Message --------
Subject: Re: [skelJS] skel.lock Cookie (#15)
Date: 10/30/2013 4:01 PM

Implemented in 0.4.3 (see usePerpetualLock and useDomainLock options).

—
Reply to this email directly or view it on GitHub
#15 (comment).