Giter Site home page Giter Site logo

Comments (5)

stuartio avatar stuartio commented on June 15, 2024

Interesting suggestion! Might be easier to make the session function simply set environment variables, since this method is used a lot with other tools (e.g. Docker). This might interfere with users who assume subsequent functions are using .edgerc files but we could write a warning to the shell if that were the case. What do you think?

from akamaipowershell.

brantpeery avatar brantpeery commented on June 15, 2024

I hesitate to store anything in the registry that is not encrypted. It would be better to store in in the Credential store when in windows, and some other keyring in other OSes.
As for the use of edgerc caching, I think that if the edgerc parameter is used it could override the use of the cached credentials. That way a person could include the edgerc file location only when they really wanted a refresh of the stored/cached credentials. Storing the creds may be overkill for this enhancement as the use case really only deals with being able to pass the creds in a parameter instead of using an edgerc file.
Personally I don't like edgerc files because it stores the secret information in plain text for anyone with access to the file system to see. This often results in unintended access to the secrets. It is just bad security practice, no matter how many big companies use the pattern.

from akamaipowershell.

brantpeery avatar brantpeery commented on June 15, 2024

I have most of this already written. I can check it in an do a pull request if you agree that it would be a good enhancement.

from akamaipowershell.

stuartio avatar stuartio commented on June 15, 2024

Sure, I'd be keen to see what you've designed. I will likely implement support for environment variables anyway, since it is in line with other Akamai tools we are developing, but there is no harm in additional methods. I could add support for specifying the host, access token, client token and client secret as parameters, but it would require editing all 600+ functions to support it, which is the only reason I am hesitant to do so.

from akamaipowershell.

stuartio avatar stuartio commented on June 15, 2024

Can you rebase your PR please? I merged in some fairly large changes to the Invoke-AkamaiRestMethod function, though it shouldn't change your logic

from akamaipowershell.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.