Comments (9)
I will confirm these issue, thanks
from mpegts.
@andersc can you outline the neccessary fixes? we also used a fork and are restrcutruring a bit. also your code seems to have moved into a repo which has no shared history with this one, so its hard to merge
from mpegts.
I just checked, the only use of string is in PMTElementInfo, should that be replaces by vector or such?
from mpegts.
@maddanio I made so many changes to the original repo it's not possible for me to be that specific. Just fork my clone to get to where I'm at ->
https://github.com/Unit-X/mpegts
Then just pullrequest from there.
/Anders
from mpegts.
Ok, i tried porting your unit tests, but I think its too hard, so i switched to your fork. One thing: in both versions the demuxer is sensitive to the block size it is fed. Basically the simple buffer borders must somehow align with the demuxer granularity, otherwise things just fail oddly. I would advice a streaming input here, i.e. either an std istream or a callback. Easiest would likely be the latter, and then plug that into simple buffer.
from mpegts.
OK. Great you found a bug. Would it be possible for you to write a failing unit test? Then I'll fix it. Or provide more detailed information.
from mpegts.
Hmm, thats tricky, I think you kinda assert that packet size is divisible by 188 in your tests, which seems to be a magic number. its kinda obvious though that it is fragile like that, as the demuxer very rarely checks for emptiness of the buffer, i.e. it being used up, but happily reads from it the rest of the time. in debug mode that will probably trigger the assertions in the simple buffer
from mpegts.
let me try...
from mpegts.
from mpegts.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpegts.