Crash when maximizing window

[shiena]

Crash when maximizing window

[shiena]

I found a pull requests that fixes the same error message. I'm not sure if this fixes it in the same way.
wailsapp/wails#2152

[akiyosi]

I also reproduced this problem in another operation.
However, I have not been able to identify the conditions to reproduce it at 100%.
Apparently, it seems to happen rarely when other window operations occur while Goneovim is running...

[shiena]

There is a fix for the same error message in golang itself. This fix has been incorporated in golang 1.22.2.
golang/go#60007

[akiyosi]

@shiena
Hi :D
Hmmm, I have not yet been able to reproduce this on my M1 Mac.
Is it reproducible in your environment?
Also, are you using any other Apps/Tools on the OS that involve window controls?

[shiena]

@akiyosi
Crash when enabling stage manager. There was no problem with Stage Manager being disabled.

[shiena]

Additionally, I found that enabling DesktopNotifications and Stage Manager sometimes causes a crash on startup.

crash log

signal 16 received but handler not on signal stack
mp.gsignal stack [0x14000004000 0x1400000c000], mp.g0 stack [0x16d4f84e8 0x16dcf3520], sp=0x14000185f18
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

runtime stack:
runtime.throw({0x10333585d?, 0x300000006?})
	runtime/panic.go:1077 +0x40 fp=0x14000185e60 sp=0x14000185e30 pc=0x10214c4b0
runtime.sigNotOnStack(0x10, 0x14000185ef0?, 0x103b60b00)
	runtime/signal_unix.go:1045 +0x118 fp=0x14000185ea0 sp=0x14000185e60 pc=0x102163968
runtime.adjustSignalStack(0x10, 0x103b60b00, 0x14000185f48)
	runtime/signal_unix.go:592 +0x25c fp=0x14000185f10 sp=0x14000185ea0 pc=0x102162a1c
runtime.sigtrampgo(0x10, 0x140001860b0, 0x14000186118)
	runtime/signal_unix.go:480 +0x8c fp=0x14000185f90 sp=0x14000185f10 pc=0x10216255c
runtime.sigtrampgo(0x10, 0x140001860b0, 0x14000186118)
	<autogenerated>:1 +0x1c fp=0x14000185fc0 sp=0x14000185f90 pc=0x1021814ec
runtime.sigtramp()
	runtime/sys_darwin_arm64.s:227 +0x4c fp=0x14000186080 sp=0x14000185fc0 pc=0x1021805bc

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x1400005afe0 sp=0x1400005afe0 pc=0x10217f5b4

goroutine 1 [running, locked to thread]:
	goroutine running on other thread; stack unavailable

goroutine 2 [force gc (idle)]:
runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
	runtime/proc.go:398 +0xc8 fp=0x14000046f90 sp=0x14000046f70 pc=0x10214f208
runtime.goparkunlock(...)
	runtime/proc.go:404
runtime.forcegchelper()
	runtime/proc.go:322 +0xb8 fp=0x14000046fd0 sp=0x14000046f90 pc=0x10214f098
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x14000046fd0 sp=0x14000046fd0 pc=0x10217f5b4
created by runtime.init.6 in goroutine 1
	runtime/proc.go:310 +0x24

goroutine 3 [GC sweep wait]:
runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
	runtime/proc.go:398 +0xc8 fp=0x14000047760 sp=0x14000047740 pc=0x10214f208
runtime.goparkunlock(...)
	runtime/proc.go:404
runtime.bgsweep(0x0?)
	runtime/mgcsweep.go:280 +0xa0 fp=0x140000477b0 sp=0x14000047760 pc=0x10213bb50
runtime.gcenable.func1()
	runtime/mgc.go:200 +0x28 fp=0x140000477d0 sp=0x140000477b0 pc=0x102130648
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x140000477d0 sp=0x140000477d0 pc=0x10217f5b4
created by runtime.gcenable in goroutine 1
	runtime/mgc.go:200 +0x6c

goroutine 4 [GC scavenge wait]:
runtime.gopark(0x14000070000?, 0x1033b16b8?, 0x1?, 0x0?, 0x140000031e0?)
	runtime/proc.go:398 +0xc8 fp=0x14000047f50 sp=0x14000047f30 pc=0x10214f208
runtime.goparkunlock(...)
	runtime/proc.go:404
runtime.(*scavengerState).park(0x103b60520)
	runtime/mgcscavenge.go:425 +0x5c fp=0x14000047f80 sp=0x14000047f50 pc=0x1021393fc
runtime.bgscavenge(0x0?)
	runtime/mgcscavenge.go:653 +0x44 fp=0x14000047fb0 sp=0x14000047f80 pc=0x102139954
runtime.gcenable.func2()
	runtime/mgc.go:201 +0x28 fp=0x14000047fd0 sp=0x14000047fb0 pc=0x1021305e8
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x14000047fd0 sp=0x14000047fd0 pc=0x10217f5b4
created by runtime.gcenable in goroutine 1
	runtime/mgc.go:201 +0xac

goroutine 5 [finalizer wait]:
runtime.gopark(0x140000465a8?, 0x10217a924?, 0x1?, 0x65?, 0x102195e44?)
	runtime/proc.go:398 +0xc8 fp=0x14000046580 sp=0x14000046560 pc=0x10214f208
runtime.runfinq()
	runtime/mfinal.go:193 +0x108 fp=0x140000467d0 sp=0x14000046580 pc=0x10212f6f8
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x140000467d0 sp=0x140000467d0 pc=0x10217f5b4
created by runtime.createfing in goroutine 1
	runtime/mfinal.go:163 +0x80

goroutine 18 [select]:
runtime.gopark(0x14000048768?, 0x2?, 0x0?, 0x0?, 0x140000486e4?)
	runtime/proc.go:398 +0xc8 fp=0x14000212d60 sp=0x14000212d40 pc=0x10214f208
runtime.selectgo(0x14000212f68, 0x140000486e0, 0x0?, 0x1, 0x0?, 0x1)
	runtime/select.go:327 +0x608 fp=0x14000212e70 sp=0x14000212d60 pc=0x10215f958
os/exec.(*Cmd).watchCtx(0x14000098000, 0x140000a2060)
	os/exec/exec.go:757 +0x7c fp=0x14000212fb0 sp=0x14000212e70 pc=0x1021eb9cc
os/exec.(*Cmd).Start.func4()
	os/exec/exec.go:743 +0x2c fp=0x14000212fd0 sp=0x14000212fb0 pc=0x1021eb6ac
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x14000212fd0 sp=0x14000212fd0 pc=0x10217f5b4
created by os/exec.(*Cmd).Start in goroutine 6
	os/exec/exec.go:743 +0x788

goroutine 19 [IO wait]:
runtime.gopark(0xffffffffffffffff?, 0xffffffffffffffff?, 0x23?, 0x0?, 0x1021b0ef0?)
	runtime/proc.go:398 +0xc8 fp=0x14000325c40 sp=0x14000325c20 pc=0x10214f208
runtime.netpollblock(0x0?, 0x0?, 0x0?)
	runtime/netpoll.go:564 +0x158 fp=0x14000325c80 sp=0x14000325c40 pc=0x102148a48
internal/poll.runtime_pollWait(0x14df227b8, 0x72)
	runtime/netpoll.go:343 +0xa0 fp=0x14000325cb0 sp=0x14000325c80 pc=0x102179870
internal/poll.(*pollDesc).wait(0x1400009e0c0?, 0x140000bb000?, 0x1)
	internal/poll/fd_poll_runtime.go:84 +0x28 fp=0x14000325ce0 sp=0x14000325cb0 pc=0x1021c4918
internal/poll.(*pollDesc).waitRead(...)
	internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x1400009e0c0, {0x140000bb000, 0x1000, 0x1000})
	internal/poll/fd_unix.go:164 +0x200 fp=0x14000325d80 sp=0x14000325ce0 pc=0x1021c53d0
os.(*File).read(...)
	os/file_posix.go:29
os.(*File).Read(0x1400008e018, {0x140000bb000?, 0x38?, 0x1037f4420?})
	os/file.go:118 +0x70 fp=0x14000325dc0 sp=0x14000325d80 pc=0x1021c8890
bufio.(*Reader).fill(0x1400009e1e0)
	bufio/bufio.go:113 +0xf8 fp=0x14000325e00 sp=0x14000325dc0 pc=0x102290c88
bufio.(*Reader).ReadByte(0x1400009e1e0)
	bufio/bufio.go:272 +0x2c fp=0x14000325e20 sp=0x14000325e00 pc=0x10229145c
github.com/neovim/go-client/msgpack.(*Decoder).Unpack(0x140000bc050)
	github.com/neovim/[email protected]/msgpack/unpack.go:164 +0x30 fp=0x14000325ea0 sp=0x14000325e20 pc=0x1022e2df0
github.com/neovim/go-client/msgpack/rpc.(*Endpoint).Serve(0x1400009c0d0)
	github.com/neovim/[email protected]/msgpack/rpc/rpc.go:195 +0xf8 fp=0x14000325f30 sp=0x14000325ea0 pc=0x1022e5198
github.com/neovim/go-client/nvim.(*Nvim).Serve(0x0?)
	github.com/neovim/[email protected]/nvim/nvim.go:50 +0xc0 fp=0x14000325f80 sp=0x14000325f30 pc=0x102314410
github.com/akiyosi/goneovim/editor.startNvim.func1()
	github.com/akiyosi/goneovim/editor/nvim.go:122 +0x2c fp=0x14000325fd0 sp=0x14000325f80 pc=0x10233847c
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x14000325fd0 sp=0x14000325fd0 pc=0x10217f5b4
created by github.com/akiyosi/goneovim/editor.startNvim in goroutine 6
	github.com/akiyosi/goneovim/editor/nvim.go:121 +0x504

goroutine 20 [chan receive]:
runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
	runtime/proc.go:398 +0xc8 fp=0x140003216a0 sp=0x14000321680 pc=0x10214f208
runtime.chanrecv(0x14000070070, 0x0, 0x1)
	runtime/chan.go:583 +0x414 fp=0x14000321720 sp=0x140003216a0 pc=0x10211db34
runtime.chanrecv1(0x1?, 0x0?)
	runtime/chan.go:442 +0x14 fp=0x14000321750 sp=0x14000321720 pc=0x10211d714
github.com/akiyosi/goneovim/editor.handleNotification.func1({0x1400035e000, 0x6, 0x6})
	github.com/akiyosi/goneovim/editor/nvim.go:224 +0x50 fp=0x14000321780 sp=0x14000321750 pc=0x102338ab0
runtime.call32(0x14000296090, 0x14000302030, 0x0, 0x0, 0x0, 0x18, 0x14000321ce0)
	runtime/asm_arm64.s:479 +0x78 fp=0x140003217b0 sp=0x14000321780 pc=0x10217d578
runtime.reflectcall(0x1037b9dc0?, 0x140003435d8?, 0x4?, 0x332b48c?, 0x1?, 0x12?, 0x1037b9dc0?)
	<autogenerated>:1 +0x34 fp=0x140003217f0 sp=0x140003217b0 pc=0x102181564
reflect.Value.call({0x1037bec60?, 0x14000302030?, 0x13?}, {0x103328098, 0x9}, {0x140003435c0, 0x1, 0x1?})
	reflect/value.go:596 +0x994 fp=0x14000321e70 sp=0x140003217f0 pc=0x1021a2444
reflect.Value.CallSlice({0x1037bec60?, 0x14000302030?, 0x0?}, {0x140003435c0?, 0x0?, 0x1400009c198?})
	reflect/value.go:393 +0x94 fp=0x14000321ef0 sp=0x14000321e70 pc=0x1021a1a04
reflect.Value.CallSlice-fm({0x140003435c0?, 0x0?, 0x0?})
	<autogenerated>:1 +0x4c fp=0x14000321f30 sp=0x14000321ef0 pc=0x1022e89dc
github.com/neovim/go-client/msgpack/rpc.(*Endpoint).runNotifications(0x1400009c0d0)
	github.com/neovim/[email protected]/msgpack/rpc/rpc.go:677 +0x78 fp=0x14000321fb0 sp=0x14000321f30 pc=0x1022e8648
github.com/neovim/go-client/msgpack/rpc.(*Endpoint).Serve.func2()
	github.com/neovim/[email protected]/msgpack/rpc/rpc.go:192 +0x28 fp=0x14000321fd0 sp=0x14000321fb0 pc=0x1022e53f8
runtime.goexit()
	runtime/asm_arm64.s:1197 +0x4 fp=0x14000321fd0 sp=0x14000321fd0 pc=0x10217f5b4
created by github.com/neovim/go-client/msgpack/rpc.(*Endpoint).Serve in goroutine 19
	github.com/neovim/[email protected]/msgpack/rpc/rpc.go:192 +0xec

[akiyosi]

Thanks for the info!

Hmmm, I have not been able to reproduce this in my environment...
There may be some other conditions.

[shiena]

Perhaps the difference in CPUs may have an impact.
My environments that crash are M2 Pro and M3.

[shiena]

I tried building with go 1.22.2 but unfortunately it did not solve the problem.