Giter Site home page Giter Site logo

Comments (7)

alanhamlett avatar alanhamlett commented on May 18, 2024 1

Fixed with 51074bb.

from pip-update-requirements.

alanhamlett avatar alanhamlett commented on May 18, 2024

It does default to zero exit code on success, and non-zero on error. The only time exit code 10 is used is when --nonzero-exit-code is present, so scripts can use the exit code when they need to know if packages were updated or not. This feature was added with #5.

from pip-update-requirements.

kkirsche avatar kkirsche commented on May 18, 2024

Which doesn’t align with tools like black in check mode. The idea would be that even in non zero exit code you would still use 0 when no update is required. As such, why is 10 used instead when all is good and it was successful. It makes sense to return something when packages need an update but not when it ran successfully and it doesn’t have any packages to update

from pip-update-requirements.

alanhamlett avatar alanhamlett commented on May 18, 2024

Oh, got it. We can change that in a major release to exit zero when everything is up to date.

from pip-update-requirements.

alanhamlett avatar alanhamlett commented on May 18, 2024

@kichik and @pradyunsg, before we change the nonzero exit code behavior to exit with 0 instead of 10 when no packages were updated, I want to check with you first. Would 0 exit code work for you? The 11 exit code would still be used when --nonzero-exit-code present and any packages needed updating.

from pip-update-requirements.

pradyunsg avatar pradyunsg commented on May 18, 2024

I'm not sure why I've been mentioned here. I have no clue what this discussion is about. :)

from pip-update-requirements.

kichik avatar kichik commented on May 18, 2024

Sorry for the very late reply, but I just now realized why you asked me and @pradyunsg and it's because of issue #5. I no longer use pur, so the change doesn't affect me. Thanks for checking!

from pip-update-requirements.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.