Memory in publish not freed when exchange doesn't exist anymore

[alanxz]

Memory in publish not freed when exchange doesn't exist anymore

[alanxz]

Did you happen to catch where the memory is piling up?

I'm going to guess its the channel.close method frames hanging around and that some cleanup is needed when a channel closes

[noldus]

I did go as far as the AmqpClient::Detail::Channel::BasicPublish method, but I can take it a step further if this helps you.

[alanxz]

I've pushed what I think is a fix for your issue in the issue28_exception_frame_free branch. (see #29). You want to give that a shot see if it fixes your issue, I'd appreciate the feedback.

[noldus]

Thanks for the quick response. I tried your patch and indeed it fixes the issue. I don't know if this is your final solution, but I would like to propose a small improvement. The fix now throws an exception which doesn't have a meaning when I catch it. In the previous situation I could catch the exception which corresponded to a non-existing exchange. Is it possible to rethrow the original exception? Like I did below?

try
{
AmqpException::Throw(*reinterpret_cast<amqp_channel_close_t*>(incoming_frame.payload.method.decoded));
}
catch (AmqpException& e)
{
MaybeReleaseBuffers();
throw e;   <<<<<<<< Is it possible to rethrow the original exception?
}

[alanxz]

Believe it or not my code does do the right thing. When you throw inside a catch statement without an argument it rethrows the original exception.

Your code will cause the exception to be copied using the copy constructor that copies exception is then thrown.

See this: http://stackoverflow.com/questions/2360597/c-exceptions-questions-on-rethrow-of-original-exception

[noldus]

Yes, you're right. I didn't know that, so I learned something here.

I was shuffeling around with the libraries to see the difference in behaviour and by accident loaded the old version. I guess something went wrong here.

When do you think you can push the fix to the trunk?

[alanxz]

The patch seems to have minimal impact. I'll probably merge it later this evening when I have a moment.

[alanxz]

Merged.

[noldus]

Thank you very much!

[chenyujian]

i just met this problem,thank you for reporting and quickly solving this bug,