Giter Site home page Giter Site logo

Comments (5)

alanxz avatar alanxz commented on July 28, 2024

I think this is doable.

The minimal information needed to do the BasicAck is the DeliveryTag and the channel id which is not publicly exposed.

I could see solving this two ways:

  • Providing a way for user's to release the BasicMessage object so its memory gets deleted, then keep the BasicAck interface the way it is.
  • Create an object that contains the DeliveryTag/channel id tuple, then have a BasicAck overload that takes that object.

from simpleamqpclient.

EmielBruijntjes avatar EmielBruijntjes commented on July 28, 2024

The second interface looks prettier.

from simpleamqpclient.

alanxz avatar alanxz commented on July 28, 2024

I agree with you there. I think that's the direction I will go on this.

from simpleamqpclient.

alanxz avatar alanxz commented on July 28, 2024

This feature is now in the master branch!

from simpleamqpclient.

EmielBruijntjes avatar EmielBruijntjes commented on July 28, 2024

Good to see. Thanks.

from simpleamqpclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.